Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Bump minimum required versions of numpy and pandas #44131

Open
jorisvandenbossche opened this issue Sep 16, 2024 · 0 comments
Open

[Python] Bump minimum required versions of numpy and pandas #44131

jorisvandenbossche opened this issue Sep 16, 2024 · 0 comments

Comments

@jorisvandenbossche
Copy link
Member

#43970 is dropping Python 3.8 for pyarrow, and as a consequence the tested minimum versions of numpy and pandas had effectively to be bumped numpy from 1.16 to 1.19.5 and pandas from 1.0 to 1.1.3.

But we should bump those minimum versions more officially, and update our code/packaging to do so:

  • In pandas-shim.pxi we explicitly check for the pandas version to raise an error if too old, so this version can be updated as well
  • We declare "numpy >= 1.16.6" in pyproject.toml, which needs to be updated.
  • We have some tests that can be cleaned up (that check for the numpy/pandas version)

While for supporting Python >= 3.9, we effectively need to bumpy to pandas 1.1.3 and numpy 1.19.5, I think we could do a bit bigger bump, and the proposal is to bump mimimal support to:

  • numpy 1.23
  • pandas 1.5

For pandas, 1.5 is the last release in the 1.x cycle (and was released Sept 2022, so two years ago). And for numpy if we look at a similar time range as pandas 1.5 in terms of when it was released, then numpy 1.23 or 1.24 also makes sense. Although for numpy's range of 1.16 - 1.24, we don't have any special case in our tests, based on a quick look (except for skipped tests for dlpack), so we can also easily be more conservative for numpy and use a longer support window here.

(given we don't really have issues regularly with older numpy, I think I personally lean to be more conservative)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant