-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support writer owns the schema #56
Comments
Do you need to keep the inner_writer as a field ? |
For example, I want user to use the writer like following:
In this case, I have to cache the content of each write. When the user calls close, create an Avro writer and write all cached content at once. |
You can experiment and propose a PR but I think it will lead to too many API breaks and probably many clone()s of the Schema. |
Closing the issue. |
Currently, the writer needs to take a lifetime param and this will make it hard to include in struct sometimes. E.g.
Even though OutWriter owns the avro_schema, it still needs to define the lifetime param explicitly. And this lifetime will continue to propagate to other types. Self-reference seems a complicated problem https://users.rust-lang.org/t/how-can-we-teach-people-about-self-referential-types/65362/2. So could we just provide a writer who owns the schema and avoids the lifetime param?🤔
The text was updated successfully, but these errors were encountered: