From 5847d118cb847aeab6f8754357b93b558083ff4f Mon Sep 17 00:00:00 2001
From: James Netherton <jamesnetherton@gmail.com>
Date: Fri, 11 Aug 2023 13:15:41 +0100
Subject: [PATCH] Unban com.google.code.findbugs:jsr305 for gRPC extension

Fixes #5167
---
 extensions/grpc/deployment/pom.xml        |  6 ---
 extensions/grpc/pom.xml                   | 48 +++++++++++++++++++++++
 extensions/grpc/runtime/pom.xml           |  6 ---
 integration-tests/grpc/pom.xml            | 43 ++++++++++++++++++++
 tooling/enforcer-rules/allow-findbugs.xsl | 33 ++++++++++++++++
 5 files changed, 124 insertions(+), 12 deletions(-)
 create mode 100644 tooling/enforcer-rules/allow-findbugs.xsl

diff --git a/extensions/grpc/deployment/pom.xml b/extensions/grpc/deployment/pom.xml
index c72f7a5dc5c6..bd471510df51 100644
--- a/extensions/grpc/deployment/pom.xml
+++ b/extensions/grpc/deployment/pom.xml
@@ -33,12 +33,6 @@
         <dependency>
             <groupId>io.quarkus</groupId>
             <artifactId>quarkus-grpc-common-deployment</artifactId>
-            <exclusions>
-                <exclusion>
-                    <groupId>com.google.code.findbugs</groupId>
-                    <artifactId>jsr305</artifactId>
-                </exclusion>
-            </exclusions>
         </dependency>
         <dependency>
             <groupId>org.apache.camel.quarkus</groupId>
diff --git a/extensions/grpc/pom.xml b/extensions/grpc/pom.xml
index ad3545f953c2..b9958962b6c5 100644
--- a/extensions/grpc/pom.xml
+++ b/extensions/grpc/pom.xml
@@ -34,4 +34,52 @@
         <module>deployment</module>
         <module>runtime</module>
     </modules>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-enforcer-plugin</artifactId>
+                <dependencies>
+                    <dependency>
+                        <groupId>io.quarkus</groupId>
+                        <artifactId>quarkus-enforcer-rules</artifactId>
+                        <version>${quarkus.version}</version>
+                    </dependency>
+                    <dependency>
+                        <groupId>org.l2x6.cq</groupId>
+                        <artifactId>cq-filtered-external-enforcer-rules</artifactId>
+                        <version>${cq-plugin.version}</version>
+                    </dependency>
+                </dependencies>
+                <executions>
+                    <execution>
+                        <id>camel-quarkus-enforcer-rules</id>
+                        <goals>
+                            <goal>enforce</goal>
+                        </goals>
+                        <configuration>
+                            <rules>
+                                <dependencyConvergence />
+                                <filteredExternalRules>
+                                    <location>classpath:enforcer-rules/quarkus-require-maven-version.xml</location>
+                                </filteredExternalRules>
+                                <filteredExternalRules>
+                                    <location>classpath:enforcer-rules/quarkus-banned-dependencies.xml</location>
+                                    <xsltLocation>${maven.multiModuleProjectDirectory}/tooling/enforcer-rules/quarkus-banned-dependencies.xsl</xsltLocation>
+                                </filteredExternalRules>
+                                <filteredExternalRules>
+                                    <location>${maven.multiModuleProjectDirectory}/tooling/enforcer-rules/camel-quarkus-banned-dependencies.xml</location>
+                                    <xsltLocation>${maven.multiModuleProjectDirectory}/tooling/enforcer-rules/allow-findbugs.xsl</xsltLocation>
+                                </filteredExternalRules>
+                                <filteredExternalRules>
+                                    <location>${maven.multiModuleProjectDirectory}/tooling/enforcer-rules/camel-quarkus-banned-dependencies-spring.xml</location>
+                                </filteredExternalRules>
+                            </rules>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>
+        </plugins>
+    </build>
 </project>
diff --git a/extensions/grpc/runtime/pom.xml b/extensions/grpc/runtime/pom.xml
index ea022e6006ec..76d178564121 100644
--- a/extensions/grpc/runtime/pom.xml
+++ b/extensions/grpc/runtime/pom.xml
@@ -38,12 +38,6 @@
         <dependency>
             <groupId>io.quarkus</groupId>
             <artifactId>quarkus-grpc-common</artifactId>
-            <exclusions>
-                <exclusion>
-                    <groupId>com.google.code.findbugs</groupId>
-                    <artifactId>jsr305</artifactId>
-                </exclusion>
-            </exclusions>
         </dependency>
         <dependency>
             <groupId>org.apache.camel.quarkus</groupId>
diff --git a/integration-tests/grpc/pom.xml b/integration-tests/grpc/pom.xml
index d9e234f98737..c2e4dfee39f8 100644
--- a/integration-tests/grpc/pom.xml
+++ b/integration-tests/grpc/pom.xml
@@ -84,6 +84,49 @@
 
     <build>
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-enforcer-plugin</artifactId>
+                <dependencies>
+                    <dependency>
+                        <groupId>io.quarkus</groupId>
+                        <artifactId>quarkus-enforcer-rules</artifactId>
+                        <version>${quarkus.version}</version>
+                    </dependency>
+                    <dependency>
+                        <groupId>org.l2x6.cq</groupId>
+                        <artifactId>cq-filtered-external-enforcer-rules</artifactId>
+                        <version>${cq-plugin.version}</version>
+                    </dependency>
+                </dependencies>
+                <executions>
+                    <execution>
+                        <id>camel-quarkus-enforcer-rules</id>
+                        <goals>
+                            <goal>enforce</goal>
+                        </goals>
+                        <configuration>
+                            <rules>
+                                <dependencyConvergence />
+                                <filteredExternalRules>
+                                    <location>classpath:enforcer-rules/quarkus-require-maven-version.xml</location>
+                                </filteredExternalRules>
+                                <filteredExternalRules>
+                                    <location>classpath:enforcer-rules/quarkus-banned-dependencies.xml</location>
+                                    <xsltLocation>${maven.multiModuleProjectDirectory}/tooling/enforcer-rules/quarkus-banned-dependencies.xsl</xsltLocation>
+                                </filteredExternalRules>
+                                <filteredExternalRules>
+                                    <location>${maven.multiModuleProjectDirectory}/tooling/enforcer-rules/camel-quarkus-banned-dependencies.xml</location>
+                                    <xsltLocation>${maven.multiModuleProjectDirectory}/tooling/enforcer-rules/allow-findbugs.xsl</xsltLocation>
+                                </filteredExternalRules>
+                                <filteredExternalRules>
+                                    <location>${maven.multiModuleProjectDirectory}/tooling/enforcer-rules/camel-quarkus-banned-dependencies-spring.xml</location>
+                                </filteredExternalRules>
+                            </rules>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>
             <plugin>
                 <groupId>kr.motd.maven</groupId>
                 <artifactId>os-maven-plugin</artifactId>
diff --git a/tooling/enforcer-rules/allow-findbugs.xsl b/tooling/enforcer-rules/allow-findbugs.xsl
new file mode 100644
index 000000000000..1629e98685c7
--- /dev/null
+++ b/tooling/enforcer-rules/allow-findbugs.xsl
@@ -0,0 +1,33 @@
+<!--
+
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to You under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+         http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+
+-->
+<xsl:stylesheet version="1.0"
+ xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
+
+ <xsl:output omit-xml-declaration="yes"/>
+
+    <xsl:template match="node()|@*">
+      <xsl:copy>
+         <xsl:apply-templates select="node()|@*"/>
+      </xsl:copy>
+    </xsl:template>
+
+    <!-- Allows findbugs usage in the gRPC extension -->
+    <!-- https://github.com/apache/camel-quarkus/issues/5167 -->
+    <xsl:template match="//bannedDependencies/excludes/exclude[contains(text(), 'com.google.code.findbugs:jsr305')]"/>
+</xsl:stylesheet>