Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi-java deployment module fails to compile due to missing DefinitionReader class #6498

Closed
jamesnetherton opened this issue Sep 20, 2024 · 3 comments
Assignees
Milestone

Comments

@jamesnetherton
Copy link
Contributor

jamesnetherton commented Sep 20, 2024

io.smallrye.openapi.runtime.io.definition.DefinitionReader is removed in SmallRye OpenAPI 3.12, which breaks the build time logic in the openapi-java extension here:

https://github.com/apache/camel-quarkus/blob/main/extensions/openapi-java/deployment/src/main/java/org/apache/camel/quarkus/component/openapi/java/deployment/OpenApiJavaProcessor.java#L242-L244

The only fix I found is to use OpenApiParser.

https://github.com/apache/camel-quarkus/blob/quarkus-main/extensions/openapi-java/deployment/src/main/java/org/apache/camel/quarkus/component/openapi/java/deployment/OpenApiJavaProcessor.java#L232-L237

But, that class is marked as deprecated and has a comment stating that it may be removed or have reduced visibility in the future. So we probably need to find an alternate solution.

@jamesnetherton jamesnetherton changed the title [quarkus-main] openapi-java deployment fails to compile due to missing DefinitionReader class [quarkus-main] openapi-java deployment module fails to compile due to missing DefinitionReader class Sep 20, 2024
@zhfeng
Copy link
Contributor

zhfeng commented Sep 20, 2024

Well, I can take a look. IIRC these codes were borrowed from quarkus somewhere before.

@zhfeng zhfeng self-assigned this Sep 20, 2024
@zhfeng
Copy link
Contributor

zhfeng commented Sep 23, 2024

It could be alter to use OpenAPIDefinitionIO

@jamesnetherton
Copy link
Contributor Author

Done in #6523.

@jamesnetherton jamesnetherton added this to the 3.16.0 milestone Oct 16, 2024
@jamesnetherton jamesnetherton changed the title [quarkus-main] openapi-java deployment module fails to compile due to missing DefinitionReader class openapi-java deployment module fails to compile due to missing DefinitionReader class Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants