-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Debug
for `SessionStateBuilder
#12555
Comments
A good way to find out what is left would be to put |
I think this is also a good first issue as it has a well defined scope and it is largely mechanical (doesn't require deep codebase knowledge) Note I made a first step here: #12556 |
Here is another PR: #12557 |
take |
Added a PR: #12624 |
I started on |
Finished being able to derive Debug on SessionStateBuilder #12632 but I believe it still needs to implement formatting to be more useful |
Do you mean "derive a more usable |
I think a pretty-print debug works okay using a |
Done in #12632. The issue can be closed. |
Is your feature request related to a problem or challenge?
Part of #12550
While working on https://github.com/datafusion-contrib/datafusion-dft I found it would be nice to have Debug for SessionStateBuilder so I could debug the actual state
Describe the solution you'd like
I would like SessionStateBuilder to implement Debug
Describe alternatives you've considered
I started working on this and it turns out many of the sub structs (like
Analyzer
andOptimizer
don't implement debug). This I recommend making a series of PRs to slowly add debug to the necessary structures so we can enable it for evertthingAdditional context
No response
The text was updated successfully, but these errors were encountered: