Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insert_or_update and get_payloads methods to binary_map/binary_view_map #12594

Open
dmitrybugakov opened this issue Sep 23, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dmitrybugakov
Copy link
Contributor

Is your feature request related to a problem or challenge?

Currently, in the datafusion-functions-extra repository, we have copied binary_map and binary_view_map from DataFusion. However, the insert_or_updateand get_payloads methods are missing from the original binary_map and binary_view_map implementations in DataFusion.

To avoid code duplication and ensure that these methods are available in the original DataFusion project, it would be beneficial to move these methods to the core DataFusion repository.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@dmitrybugakov dmitrybugakov added the enhancement New feature or request label Sep 23, 2024
@dmitrybugakov
Copy link
Contributor Author

take

@jayzhan211
Copy link
Contributor

in the datafusion-functions-extra repository, we have copied binary_map and binary_view_map

Is there any reason why can't we just import from datafusion but require copying the code?

@dmitrybugakov
Copy link
Contributor Author

The reason we copied the map instead of importing directly from DataFusion is that the version in datafusion-functions-extra includes two additional methods. To avoid waiting for the next DataFusion release, we copied the map and added those methods locally.

#12385 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants