From d4878aff599d2060b56f513edb79e1d7e4b38a21 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Tue, 30 Apr 2024 11:31:49 -0400 Subject: [PATCH 1/2] Update link to list of committers in contributor guide --- docs/source/contributor-guide/index.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/source/contributor-guide/index.md b/docs/source/contributor-guide/index.md index 252848bb7132..712f9034a93f 100644 --- a/docs/source/contributor-guide/index.md +++ b/docs/source/contributor-guide/index.md @@ -68,10 +68,12 @@ ideas with the community to get feedback on implementation. We welcome pull requests (PRs) from anyone from the community. -DataFusion is a very active fast-moving project and we try to review and merge PRs quickly to keep the review backlog down and the pace up. After review and approval, one of the [many people with commit access](https://arrow.apache.org/committers/) will merge your PR. +DataFusion is a very active fast-moving project and we try to review and merge PRs quickly to keep the review backlog down and the pace up. After review and approval, one of the [many people with commit access] will merge your PR. Review bandwidth is currently our most limited resource, and we highly encourage reviews by the broader community. If you are waiting for your PR to be reviewed, consider helping review other PRs that are waiting. Such review both helps the reviewer to learn the codebase and become more expert, as well as helps identify issues in the PR (such as lack of test coverage), that can be addressed and make future reviews faster and more efficient. +[many people with commit access]: https://people.apache.org/phonebook.html?unix=datafusion + ## Creating Pull Requests We recommend splitting your contributions into smaller PRs rather than large PRs (500+ lines) because: From 0cc7a611e0461473961ce81ccd2d5b449fa4b743 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Tue, 30 Apr 2024 12:15:48 -0400 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: comphead --- docs/source/contributor-guide/index.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/source/contributor-guide/index.md b/docs/source/contributor-guide/index.md index 712f9034a93f..5705737206da 100644 --- a/docs/source/contributor-guide/index.md +++ b/docs/source/contributor-guide/index.md @@ -68,11 +68,11 @@ ideas with the community to get feedback on implementation. We welcome pull requests (PRs) from anyone from the community. -DataFusion is a very active fast-moving project and we try to review and merge PRs quickly to keep the review backlog down and the pace up. After review and approval, one of the [many people with commit access] will merge your PR. +DataFusion is a very active fast-moving project and we try to review and merge PRs quickly to keep the review backlog down and the pace up. After review and approval, one of the [committers] will merge your PR. Review bandwidth is currently our most limited resource, and we highly encourage reviews by the broader community. If you are waiting for your PR to be reviewed, consider helping review other PRs that are waiting. Such review both helps the reviewer to learn the codebase and become more expert, as well as helps identify issues in the PR (such as lack of test coverage), that can be addressed and make future reviews faster and more efficient. -[many people with commit access]: https://people.apache.org/phonebook.html?unix=datafusion +[committers]: https://people.apache.org/phonebook.html?unix=datafusion ## Creating Pull Requests