Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] (nereids)implement CreateRoleCommand in nereids #42597

Closed
2 of 3 tasks
Tracked by #42600
LiBinfeng-01 opened this issue Oct 28, 2024 · 1 comment · Fixed by #44814
Closed
2 of 3 tasks
Tracked by #42600

[Enhancement] (nereids)implement CreateRoleCommand in nereids #42597

LiBinfeng-01 opened this issue Oct 28, 2024 · 1 comment · Fixed by #44814
Labels
area/nereids good first issue java Pull requests that update Java code

Comments

@LiBinfeng-01
Copy link
Collaborator

Search before asking

  • I had searched in the issues and found no similar issues.

Description

CreateRoleCommand is supported in legacy planner but not in nereids(new doris fe planner). you need implement it in nereids.
The DorisParser.g4 has the syntax definition already(see bellow). And you can check CreateRoleStmt.java in legacy planner to see what the command does and migrate it to nereids planner
unsupportedCreateStatement: CREATE ROLE (IF NOT EXISTS)? name=identifier (COMMENT STRING_LITERAL)?

Solution

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@LiBinfeng-01 LiBinfeng-01 mentioned this issue Oct 28, 2024
Open
16 tasks
@starocean999 starocean999 added good first issue java Pull requests that update Java code area/nereids labels Oct 30, 2024
@Vallishp
Copy link
Contributor

i will pick it

@Vallishp Vallishp mentioned this issue Nov 30, 2024
Merged
16 tasks
starocean999 pushed a commit that referenced this issue Dec 2, 2024
@Vallishp
[Enhancement] (nereids)implement CreateRoleCommand in nereids (#44814)
54fe0b4 
Issue Number: close #42597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/nereids good first issue java Pull requests that update Java code
Projects
impl all command in Nereids
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Enhancement] (nereids)implement CreateRoleCommand in nereids Vallishp/doris
3 participants
@Vallishp @starocean999 @LiBinfeng-01