Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor](block) Refactor interface of shrink column #44046

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Nov 15, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

dont alloc new mem and re-assign. just shirnk in place.

Load Average: 41.85, 77.08, 85.46
-----------------------------------------------------
Benchmark           Time             CPU   Iterations
-----------------------------------------------------
optimized  6.0394e+13 ns    164638033 ns            1
origin     6.0395e+13 ns   1095925699 ns            1

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.01% (9901/26051)
Line Coverage: 29.19% (82750/283470)
Region Coverage: 28.32% (42501/150068)
Branch Coverage: 24.89% (21550/86570)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d436b7641c95883b38411f7fe27f274a6b63982f_d436b7641c95883b38411f7fe27f274a6b63982f/report/index.html

@zclllyybb zclllyybb marked this pull request as ready for review November 17, 2024 17:49
@zclllyybb
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.99% (9902/26068)
Line Coverage: 29.19% (82785/283643)
Region Coverage: 28.32% (42508/150113)
Branch Coverage: 24.89% (21557/86596)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bdf93b3207d32e437039aeaa7ca1cb17f590d0ad_bdf93b3207d32e437039aeaa7ca1cb17f590d0ad/report/index.html

@zclllyybb
Copy link
Contributor Author

run buildlall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zclllyybb zclllyybb force-pushed the refactor_shrink_chars branch from 290e2ab to 5078813 Compare November 18, 2024 08:13
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zclllyybb zclllyybb force-pushed the refactor_shrink_chars branch from 5078813 to 0bf7cec Compare November 18, 2024 08:41
@zclllyybb
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.02% (9899/26035)
Line Coverage: 29.18% (82739/283502)
Region Coverage: 28.32% (42499/150048)
Branch Coverage: 24.89% (21552/86584)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0bf7cec3b29d3c49d1be1a8df9a624228646fabf_0bf7cec3b29d3c49d1be1a8df9a624228646fabf/report/index.html

@zclllyybb zclllyybb requested a review from HappenLee November 18, 2024 12:53
@zclllyybb zclllyybb force-pushed the refactor_shrink_chars branch from 0bf7cec to ab7d216 Compare November 19, 2024 02:24
@zclllyybb
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zclllyybb zclllyybb force-pushed the refactor_shrink_chars branch from ab7d216 to 4618c73 Compare November 19, 2024 02:44
@zclllyybb
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 19, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.02% (9898/26035)
Line Coverage: 29.20% (82796/283507)
Region Coverage: 28.33% (42512/150048)
Branch Coverage: 24.90% (21558/86584)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4618c7344a16becef94c6e4817266c9333c254eb_4618c7344a16becef94c6e4817266c9333c254eb/report/index.html

@BiteTheDDDDt BiteTheDDDDt merged commit 8be13b0 into apache:master Nov 19, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants