Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enchement](mc)mc catalog append netowrk config #44194

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

hubgeter
Copy link
Contributor

@hubgeter hubgeter commented Nov 18, 2024

What problem does this PR solve?

Since there may be some network problems when accessing maxcompute, in order to provide a better user experience, we introduce some parameters to help users better adapt to the network.

You can add these parameters when creating a catalog:
mc.connect_timeout : Connection timeout, default is 10s.
mc.read_timeout : Read timeout,default is 120s.
mc.retry_count : Number of retries after failure,default is 4.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

MaxCompute catalog add three parameters : mc.connect_timeout , mc.read_timeout,mc.retry_count help users better adapt to the network between MaxCompute and Doris.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hubgeter
Copy link
Contributor Author

hubgeter commented Dec 1, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.40% (9992/26018)
Line Coverage: 29.45% (83669/284087)
Region Coverage: 28.58% (43057/150653)
Branch Coverage: 25.20% (21882/86834)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b954d122c81bb49dccdde3e9174826ef80ac01d6_b954d122c81bb49dccdde3e9174826ef80ac01d6/report/index.html

@hubgeter
Copy link
Contributor Author

hubgeter commented Dec 2, 2024

run buildall

@hubgeter hubgeter marked this pull request as ready for review December 2, 2024 07:01
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.39% (9978/25989)
Line Coverage: 29.46% (83685/284057)
Region Coverage: 28.58% (43045/150612)
Branch Coverage: 25.20% (21884/86832)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a64be3104fc87cc75f42daccab2af59ad25e6d60_a64be3104fc87cc75f42daccab2af59ad25e6d60/report/index.html

@hubgeter
Copy link
Contributor Author

hubgeter commented Dec 5, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.47% (10008/26013)
Line Coverage: 29.53% (83930/284252)
Region Coverage: 28.63% (43135/150658)
Branch Coverage: 25.22% (21923/86916)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3571ea446d368c04c64bce20d03a3b408f3bd8ad_3571ea446d368c04c64bce20d03a3b408f3bd8ad/report/index.html

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by anyone and no changes requested.

@morningman morningman merged commit da9b818 into apache:master Dec 6, 2024
25 of 27 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 6, 2024
### What problem does this PR solve?

Since there may be some network problems when accessing maxcompute, in
order to provide a better user experience, we introduce some parameters
to help users better adapt to the network.

You can add these parameters when creating a catalog:
`mc.connect_timeout` :  Connection timeout, default is 10s.
`mc.read_timeout` : Read timeout,default is 120s.
`mc.retry_count` : Number of retries after failure,default is 4.

### Release note

MaxCompute catalog add three parameters : `mc.connect_timeout` ,
`mc.read_timeout`,`mc.retry_count` help users better adapt to the
network between MaxCompute and Doris.
morningman pushed a commit that referenced this pull request Dec 6, 2024
hubgeter added a commit to hubgeter/doris that referenced this pull request Dec 7, 2024
### What problem does this PR solve?

Since there may be some network problems when accessing maxcompute, in
order to provide a better user experience, we introduce some parameters
to help users better adapt to the network.

You can add these parameters when creating a catalog:
`mc.connect_timeout` :  Connection timeout, default is 10s.
`mc.read_timeout` : Read timeout,default is 120s.
`mc.retry_count` : Number of retries after failure,default is 4.

### Release note

MaxCompute catalog add three parameters : `mc.connect_timeout` ,
`mc.read_timeout`,`mc.retry_count` help users better adapt to the
network between MaxCompute and Doris.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants