[feat](test) add bloomfilter ut case #44351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -295,5 +296,203 @@ TEST_F(BloomFilterIndexReaderWriterTest, test_decimal) { | |||
| delete[] val; | |||
| } | |||
|
|
|||
| TEST_F(BloomFilterIndexReaderWriterTest, test_datev2) { | |||
| size_t num = 1024 * 3 - 1; | |||
| uint32_t* val = new uint32_t[num]; | |||
There was a problem hiding this comment.
warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
Suggested change
| uint32_t* val = new uint32_t[num]; | |
| auto* val = new uint32_t[num]; |
|
|
||
| TEST_F(BloomFilterIndexReaderWriterTest, test_datetimev2) { | ||
| size_t num = 1024 * 3 - 1; | ||
| uint64_t* val = new uint64_t[num]; |
There was a problem hiding this comment.
warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
Suggested change
| uint64_t* val = new uint64_t[num]; | |
| auto* val = new uint64_t[num]; |
|
|
||
| TEST_F(BloomFilterIndexReaderWriterTest, test_decimal32) { | ||
| size_t num = 1024 * 3 - 1; | ||
| int32_t* val = new int32_t[num]; |
There was a problem hiding this comment.
warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
Suggested change
| int32_t* val = new int32_t[num]; | |
| auto* val = new int32_t[num]; |
| delete[] val; | ||
| } | ||
|
|
||
| void test_ngram_bloom_filter_index_reader_writer(const std::string& file_name, Slice* values, |
There was a problem hiding this comment.
warning: function 'test_ngram_bloom_filter_index_reader_writer' exceeds recommended size/complexity thresholds [readability-function-size]
void test_ngram_bloom_filter_index_reader_writer(const std::string& file_name, Slice* values,
^Additional context
be/test/olap/rowset/segment_v2/bloom_filter_index_reader_writer_test.cpp:340: 95 lines including whitespace and comments (threshold 80)
void test_ngram_bloom_filter_index_reader_writer(const std::string& file_name, Slice* values,
^
|
run buildall |
| TEST_F(BloomFilterIndexReaderWriterTest, test_decimal64) { | ||
| size_t num = 1024 * 3 - 1; | ||
| ; | ||
| int64_t* val = new int64_t[num]; |
There was a problem hiding this comment.
warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
Suggested change
| int64_t* val = new int64_t[num]; | |
| auto* val = new int64_t[num]; |
|
|
||
| TEST_F(BloomFilterIndexReaderWriterTest, test_ipv4) { | ||
| size_t num = 1024 * 3 - 1; | ||
| uint32_t* val = new uint32_t[num]; |
There was a problem hiding this comment.
warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
Suggested change
| uint32_t* val = new uint32_t[num]; | |
| auto* val = new uint32_t[num]; |
|
|
||
| TEST_F(BloomFilterIndexReaderWriterTest, test_decimal128i) { | ||
| size_t num = 1024 * 3 - 1; | ||
| int128_t* val = new int128_t[num]; |
There was a problem hiding this comment.
warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
Suggested change
| int128_t* val = new int128_t[num]; | |
| auto* val = new int128_t[num]; |
| } | ||
|
|
||
| std::string file_name = "bloom_filter_decimal128i"; | ||
| int128_t not_exist_value = int128_t(9999999999999999999ULL); |
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Suggested change
| int128_t not_exist_value = int128_t(9999999999999999999ULL); | |
| auto not_exist_value = int128_t(9999999999999999999ULL); |
|
|
||
| TEST_F(BloomFilterIndexReaderWriterTest, test_ipv6) { | ||
| size_t num = 1024 * 3 - 1; | ||
| uint128_t* val = new uint128_t[num]; |
There was a problem hiding this comment.
warning: use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
Suggested change
| uint128_t* val = new uint128_t[num]; | |
| auto* val = new uint128_t[num]; |
| delete[] val; | ||
| } | ||
|
|
||
| void test_ngram_bloom_filter_index_reader_writer(const std::string& file_name, Slice* values, |
There was a problem hiding this comment.
warning: function 'test_ngram_bloom_filter_index_reader_writer' exceeds recommended size/complexity thresholds [readability-function-size]
void test_ngram_bloom_filter_index_reader_writer(const std::string& file_name, Slice* values,
^Additional context
be/test/olap/rowset/segment_v2/bloom_filter_index_reader_writer_test.cpp:428: 95 lines including whitespace and comments (threshold 80)
void test_ngram_bloom_filter_index_reader_writer(const std::string& file_name, Slice* values,
^
TPC-H: Total hot run time: 39852 ms |
TPC-DS: Total hot run time: 196097 ms |
ClickBench: Total hot run time: 32.61 s |
|
TeamCity be ut coverage result: |
airborne12
force-pushed
the
add-bf-ut
branch
from
d4ed7c8 to
ca998c7
Compare
|
run buildall |
| delete[] val; | ||
| } | ||
|
|
||
| void test_ngram_bloom_filter_index_reader_writer(const std::string& file_name, Slice* values, |
There was a problem hiding this comment.
warning: function 'test_ngram_bloom_filter_index_reader_writer' exceeds recommended size/complexity thresholds [readability-function-size]
void test_ngram_bloom_filter_index_reader_writer(const std::string& file_name, Slice* values,
^Additional context
be/test/olap/rowset/segment_v2/bloom_filter_index_reader_writer_test.cpp:477: 95 lines including whitespace and comments (threshold 80)
void test_ngram_bloom_filter_index_reader_writer(const std::string& file_name, Slice* values,
^
TPC-H: Total hot run time: 40294 ms |
TPC-DS: Total hot run time: 197316 ms |
ClickBench: Total hot run time: 32.49 s |
|
run buildall |
| delete[] val; | ||
| } | ||
|
|
||
| void test_ngram_bloom_filter_index_reader_writer(const std::string& file_name, Slice* values, |
There was a problem hiding this comment.
warning: function 'test_ngram_bloom_filter_index_reader_writer' exceeds recommended size/complexity thresholds [readability-function-size]
void test_ngram_bloom_filter_index_reader_writer(const std::string& file_name, Slice* values,
^Additional context
be/test/olap/rowset/segment_v2/bloom_filter_index_reader_writer_test.cpp:485: 95 lines including whitespace and comments (threshold 80)
void test_ngram_bloom_filter_index_reader_writer(const std::string& file_name, Slice* values,
^
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39573 ms |
TPC-DS: Total hot run time: 196775 ms |
ClickBench: Total hot run time: 33.74 s |
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 39691 ms |
TPC-DS: Total hot run time: 196754 ms |
ClickBench: Total hot run time: 32.73 s |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40063 ms |
TPC-DS: Total hot run time: 197297 ms |
TPC-DS: Total hot run time: 198536 ms |
ClickBench: Total hot run time: 32.95 s |
|
run buildall |
TPC-H: Total hot run time: 40303 ms |
TPC-DS: Total hot run time: 190828 ms |
ClickBench: Total hot run time: 32.74 s |
|
TeamCity be ut coverage result: |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
airborne12
force-pushed
the
add-bf-ut
branch
from
ebae1c1 to
259f6bb
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40064 ms |
TPC-DS: Total hot run time: 197607 ms |
ClickBench: Total hot run time: 32.43 s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)