Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](ip) fix ip nullable param without check #44700

Merged
merged 4 commits into from
Dec 3, 2024
Merged

[fix](ip) fix ip nullable param without check #44700

merged 4 commits into from
Dec 3, 2024

Conversation

amorynan
Copy link
Contributor

What problem does this PR solve?

if we use ipv6_cidr_to_range function with nullable func which with invalid ipv6 will make be core

mysql> select id, ipv6_cidr_to_range(nullable(''), 32) from fn_test_ip_nullable order by id;


Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
        - [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
    - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.34% (9974/26017)
Line Coverage: 29.42% (83488/283780)
Region Coverage: 28.57% (42983/150449)
Branch Coverage: 25.18% (21827/86698)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c01b79bf8c161b710e3528d983e94445ec0b8d55_c01b79bf8c161b710e3528d983e94445ec0b8d55/report/index.html

zhangstar333
zhangstar333 previously approved these changes Nov 28, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 30, 2024
@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.37% (9981/26014)
Line Coverage: 29.43% (83568/283994)
Region Coverage: 28.55% (43001/150621)
Branch Coverage: 25.17% (21847/86794)
Coverage Report: http://coverage.selectdb-in.cc/coverage/96f60c30bcf9ac7c11ce70cbd247104a46fcbac1_96f60c30bcf9ac7c11ce70cbd247104a46fcbac1/report/index.html

HappenLee
HappenLee previously approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should delete the useless code of ColumnString

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2024
@amorynan
Copy link
Contributor Author

amorynan commented Dec 2, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 2, 2024
HappenLee
HappenLee approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.39% (9978/25989)
Line Coverage: 29.45% (83651/284032)
Region Coverage: 28.58% (43042/150605)
Branch Coverage: 25.20% (21883/86832)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6c3d290e792adc3ce3df51047c03db0c5a7d9fbc_6c3d290e792adc3ce3df51047c03db0c5a7d9fbc/report/index.html

@HappenLee HappenLee merged commit 702ca90 into apache:master Dec 3, 2024
24 of 27 checks passed
amorynan added a commit to amorynan/doris that referenced this pull request Jan 2, 2025
@amorynan
[fix](ip) fix ip nullable param without check (apache#44700)
1540c49 
if we use ipv6_cidr_to_range function with nullable func which with
invalid ipv6 will make be core
```
mysql> select id, ipv6_cidr_to_range(nullable(''), 32) from fn_test_ip_nullable order by id;
```
amorynan added a commit to amorynan/doris that referenced this pull request Jan 2, 2025
@amorynan
[fix](ip) fix ip nullable param without check (apache#44700)
84e9894 
if we use ipv6_cidr_to_range function with nullable func which with
invalid ipv6 will make be core
```
mysql> select id, ipv6_cidr_to_range(nullable(''), 32) from fn_test_ip_nullable order by id;
```
@HappenLee HappenLee mentioned this pull request Jan 2, 2025
Merged
16 tasks
HappenLee pushed a commit that referenced this pull request Jan 3, 2025
@amorynan
[fix](ip) fix ip nullable param without check (#44700) (#46250)
4506457 
if we use ipv6_cidr_to_range function with nullable func which with
invalid ipv6 will make be core
```
mysql> select id, ipv6_cidr_to_range(nullable(''), 32) from fn_test_ip_nullable order by id;
```

### What problem does this PR solve?


Related PR: #44700
yiguolei pushed a commit that referenced this pull request Jan 3, 2025
@amorynan
[fix](ip) fix ip nullable param without check (#44700) (#46252)
333b54e 
if we use ipv6_cidr_to_range function with nullable func which with
invalid ipv6 will make be core
```
mysql> select id, ipv6_cidr_to_range(nullable(''), 32) from fn_test_ip_nullable order by id;
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangstar333 zhangstar333 zhangstar333 approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amorynan @doris-robot @HappenLee @zhangstar333 @wm1581066 @eldenmoon