Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] (nereids)implement CreateEncryptKeyCommand in nereids #44807

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

Vallishp
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #42591

Related PR: #xxx

Problem Summary:
implement CreateEncryptKeyCommand in nereids

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Vallishp Vallishp force-pushed the nereids_create_encrypt_key branch from 2e5f576 to 80750a1 Compare November 29, 2024 18:00
@Vallishp
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40044 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 80750a1684c7cef4ae0147b3b2e44f27b6ab4813, data reload: false

------ Round 1 ----------------------------------
q1	17583	7465	7273	7273
q2	2037	173	167	167
q3	10645	1132	1207	1132
q4	10558	795	694	694
q5	7598	2740	2751	2740
q6	241	146	148	146
q7	987	628	604	604
q8	9233	1853	1895	1853
q9	6727	6474	6453	6453
q10	7019	2323	2330	2323
q11	459	264	260	260
q12	425	231	226	226
q13	17793	3079	3075	3075
q14	235	211	215	211
q15	585	542	517	517
q16	663	581	596	581
q17	981	529	613	529
q18	7183	6825	6660	6660
q19	1340	991	1033	991
q20	483	187	180	180
q21	4054	3212	3121	3121
q22	374	308	319	308
Total cold run time: 107203 ms
Total hot run time: 40044 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7238	7265	7233	7233
q2	325	230	229	229
q3	2911	2829	2970	2829
q4	2096	1820	1822	1820
q5	5671	5663	5670	5663
q6	227	145	140	140
q7	2243	1809	1792	1792
q8	3416	3562	3496	3496
q9	9000	9045	9051	9045
q10	3611	3558	3545	3545
q11	621	538	495	495
q12	815	636	618	618
q13	12050	3272	3220	3220
q14	307	271	272	271
q15	567	538	529	529
q16	682	657	653	653
q17	1879	1630	1615	1615
q18	8324	7862	7380	7380
q19	1725	1529	1613	1529
q20	2108	1850	1871	1850
q21	5590	5468	5401	5401
q22	647	597	570	570
Total cold run time: 72053 ms
Total hot run time: 59923 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198606 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 80750a1684c7cef4ae0147b3b2e44f27b6ab4813, data reload: false

query1	1236	954	979	954
query2	6251	2127	2071	2071
query3	10953	4402	4559	4402
query4	68145	29059	23612	23612
query5	4943	471	448	448
query6	408	188	177	177
query7	5473	309	303	303
query8	322	260	230	230
query9	8525	2754	2750	2750
query10	433	274	249	249
query11	17125	15378	15905	15378
query12	150	112	100	100
query13	1451	440	447	440
query14	10597	7830	7724	7724
query15	216	182	191	182
query16	7105	437	454	437
query17	1394	579	611	579
query18	1802	321	318	318
query19	203	160	154	154
query20	121	114	115	114
query21	199	108	103	103
query22	4692	4543	4516	4516
query23	34664	34529	34437	34437
query24	5426	2552	2674	2552
query25	482	379	403	379
query26	655	153	150	150
query27	2015	284	300	284
query28	4498	2534	2458	2458
query29	692	422	438	422
query30	216	149	150	149
query31	996	817	842	817
query32	69	57	56	56
query33	415	280	291	280
query34	958	538	528	528
query35	917	816	771	771
query36	1085	981	978	978
query37	123	71	84	71
query38	4596	4395	4469	4395
query39	1547	1472	1488	1472
query40	204	109	105	105
query41	46	47	40	40
query42	108	97	97	97
query43	541	500	499	499
query44	1201	838	833	833
query45	194	173	174	173
query46	1177	761	731	731
query47	2080	1941	1918	1918
query48	425	326	329	326
query49	714	380	389	380
query50	892	398	401	398
query51	7432	7210	7114	7114
query52	100	86	86	86
query53	256	191	182	182
query54	500	392	392	392
query55	81	74	71	71
query56	246	238	243	238
query57	1262	1119	1119	1119
query58	216	199	214	199
query59	3275	3178	3072	3072
query60	268	239	258	239
query61	103	102	100	100
query62	801	672	659	659
query63	209	189	199	189
query64	1372	649	642	642
query65	3316	3260	3271	3260
query66	698	306	310	306
query67	15760	15721	15718	15718
query68	3927	581	543	543
query69	436	250	259	250
query70	1162	1154	1115	1115
query71	372	252	253	252
query72	6405	4115	4067	4067
query73	765	372	365	365
query74	9584	9058	8965	8965
query75	3389	2704	2769	2704
query76	1877	1121	1123	1121
query77	456	263	272	263
query78	10484	9484	9371	9371
query79	1740	602	589	589
query80	1441	414	472	414
query81	503	233	227	227
query82	1308	120	118	118
query83	269	142	146	142
query84	297	68	72	68
query85	1018	295	286	286
query86	437	300	313	300
query87	4772	4545	4587	4545
query88	3874	2219	2192	2192
query89	427	304	300	300
query90	1967	186	190	186
query91	139	102	100	100
query92	70	49	58	49
query93	2160	554	545	545
query94	824	300	290	290
query95	360	254	253	253
query96	621	276	284	276
query97	2847	2676	2694	2676
query98	217	192	190	190
query99	1810	1345	1318	1318
Total cold run time: 320533 ms
Total hot run time: 198606 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.69 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 80750a1684c7cef4ae0147b3b2e44f27b6ab4813, data reload: false

query1	0.03	0.04	0.04
query2	0.06	0.03	0.03
query3	0.23	0.08	0.07
query4	1.63	0.10	0.11
query5	0.42	0.39	0.41
query6	1.15	0.65	0.64
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.57	0.51	0.49
query10	0.54	0.58	0.55
query11	0.14	0.10	0.10
query12	0.15	0.12	0.11
query13	0.62	0.60	0.60
query14	2.69	2.75	2.75
query15	0.91	0.83	0.84
query16	0.41	0.39	0.38
query17	0.99	1.00	1.00
query18	0.22	0.20	0.20
query19	1.90	1.83	1.88
query20	0.02	0.01	0.01
query21	15.35	0.61	0.60
query22	2.73	1.77	1.85
query23	17.21	0.92	0.75
query24	2.92	1.62	1.28
query25	0.23	0.14	0.06
query26	0.54	0.14	0.15
query27	0.05	0.04	0.05
query28	10.37	1.10	1.07
query29	12.56	3.24	3.23
query30	0.24	0.06	0.06
query31	2.87	0.40	0.38
query32	3.26	0.48	0.47
query33	3.03	3.01	2.99
query34	17.12	4.39	4.48
query35	4.49	4.51	4.52
query36	0.67	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.14	0.12
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.85 s
Total hot run time: 32.69 s

@Vallishp
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40255 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3ec5c5462189d2c8f26180c7e838cf6f3ba59b7a, data reload: false

------ Round 1 ----------------------------------
q1	17604	7479	7300	7300
q2	2056	185	162	162
q3	10564	1096	1177	1096
q4	10695	704	724	704
q5	7613	2704	2661	2661
q6	239	147	149	147
q7	975	623	611	611
q8	9237	1866	1951	1866
q9	6741	6567	6491	6491
q10	6994	2316	2340	2316
q11	464	256	256	256
q12	427	228	229	228
q13	17962	3064	3094	3064
q14	243	209	218	209
q15	573	547	505	505
q16	649	618	607	607
q17	1043	582	589	582
q18	7231	6734	6789	6734
q19	1333	985	978	978
q20	473	179	179	179
q21	4103	3263	3212	3212
q22	402	348	347	347
Total cold run time: 107621 ms
Total hot run time: 40255 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7368	7390	7302	7302
q2	335	239	245	239
q3	3072	3081	3007	3007
q4	2180	1939	1860	1860
q5	5825	5784	5782	5782
q6	231	142	140	140
q7	2234	1775	1749	1749
q8	3384	3602	3539	3539
q9	9014	8954	9031	8954
q10	3619	3521	3540	3521
q11	608	502	513	502
q12	806	593	598	593
q13	16545	3234	3234	3234
q14	306	288	270	270
q15	586	530	525	525
q16	680	672	635	635
q17	1828	1631	1703	1631
q18	8356	7836	7535	7535
q19	1790	1555	1448	1448
q20	2108	1866	1907	1866
q21	5557	5392	5257	5257
q22	653	572	593	572
Total cold run time: 77085 ms
Total hot run time: 60161 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196303 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3ec5c5462189d2c8f26180c7e838cf6f3ba59b7a, data reload: false

query1	1240	921	921	921
query2	6261	2099	2035	2035
query3	11002	4347	4439	4347
query4	67225	28695	23528	23528
query5	5040	453	429	429
query6	397	182	176	176
query7	5537	304	294	294
query8	304	226	226	226
query9	8443	2734	2713	2713
query10	439	254	254	254
query11	17319	15210	16018	15210
query12	147	103	100	100
query13	1431	433	414	414
query14	11074	7525	6742	6742
query15	210	196	191	191
query16	7073	484	461	461
query17	1215	562	560	560
query18	1780	296	317	296
query19	227	163	147	147
query20	122	117	116	116
query21	205	125	100	100
query22	4810	4480	4671	4480
query23	34756	34467	34412	34412
query24	5445	2502	2545	2502
query25	495	382	377	377
query26	630	158	162	158
query27	1768	282	289	282
query28	4654	2491	2467	2467
query29	665	418	416	416
query30	206	161	154	154
query31	1038	869	842	842
query32	65	58	58	58
query33	472	295	302	295
query34	949	524	529	524
query35	901	753	748	748
query36	1102	968	979	968
query37	134	78	85	78
query38	4552	4372	4316	4316
query39	1533	1488	1490	1488
query40	215	103	105	103
query41	45	47	46	46
query42	114	101	99	99
query43	542	507	502	502
query44	1212	857	868	857
query45	183	165	163	163
query46	1203	751	704	704
query47	2001	1935	1944	1935
query48	417	320	311	311
query49	739	400	380	380
query50	835	386	388	386
query51	7484	7282	7045	7045
query52	97	84	87	84
query53	249	174	175	174
query54	506	397	398	397
query55	74	72	75	72
query56	267	212	235	212
query57	1256	1108	1145	1108
query58	206	199	200	199
query59	3115	3079	2945	2945
query60	263	238	239	238
query61	104	107	101	101
query62	775	683	658	658
query63	208	190	176	176
query64	1354	685	628	628
query65	3267	3252	3254	3252
query66	704	301	295	295
query67	15920	15590	15641	15590
query68	4047	565	559	559
query69	424	289	252	252
query70	1213	1133	1061	1061
query71	351	246	252	246
query72	6423	4059	4020	4020
query73	823	361	361	361
query74	10169	9067	9032	9032
query75	3401	2655	2673	2655
query76	1898	988	1119	988
query77	537	269	264	264
query78	10580	9420	9467	9420
query79	2859	617	627	617
query80	1441	421	421	421
query81	515	242	238	238
query82	946	122	116	116
query83	248	139	143	139
query84	291	70	75	70
query85	1089	311	305	305
query86	423	308	290	290
query87	4828	4556	4507	4507
query88	4246	2193	2157	2157
query89	420	294	291	291
query90	2065	185	181	181
query91	143	100	100	100
query92	70	52	50	50
query93	2916	546	542	542
query94	853	288	290	288
query95	351	240	241	240
query96	629	280	273	273
query97	2829	2740	2644	2644
query98	214	191	193	191
query99	1602	1309	1300	1300
Total cold run time: 323065 ms
Total hot run time: 196303 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.36 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3ec5c5462189d2c8f26180c7e838cf6f3ba59b7a, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.08	0.07
query4	1.62	0.11	0.10
query5	0.43	0.39	0.44
query6	1.15	0.67	0.66
query7	0.01	0.02	0.02
query8	0.04	0.04	0.03
query9	0.60	0.52	0.50
query10	0.54	0.56	0.55
query11	0.14	0.11	0.11
query12	0.14	0.11	0.12
query13	0.60	0.60	0.60
query14	2.70	2.74	2.88
query15	0.91	0.84	0.83
query16	0.39	0.39	0.38
query17	1.07	1.04	1.07
query18	0.23	0.22	0.20
query19	1.95	1.86	2.03
query20	0.01	0.01	0.01
query21	15.36	0.61	0.61
query22	2.44	2.59	1.42
query23	16.87	1.14	0.74
query24	3.47	1.19	1.33
query25	0.23	0.14	0.04
query26	0.61	0.13	0.13
query27	0.04	0.05	0.04
query28	10.02	1.10	1.08
query29	12.60	3.24	3.25
query30	0.25	0.06	0.07
query31	2.87	0.38	0.39
query32	3.25	0.46	0.48
query33	3.00	3.00	3.05
query34	17.04	4.45	4.48
query35	4.55	4.47	4.50
query36	0.65	0.49	0.49
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.04	0.03	0.02
query40	0.16	0.12	0.12
query41	0.07	0.03	0.02
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.58 s
Total hot run time: 32.36 s

@Vallishp Vallishp force-pushed the nereids_create_encrypt_key branch from 3ec5c54 to e7310cc Compare December 2, 2024 03:33
@Vallishp
Copy link
Contributor Author

Vallishp commented Dec 2, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39909 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e7310cc90e8326e5282a3157a3038a5999a77145, data reload: false

------ Round 1 ----------------------------------
q1	17589	7492	7241	7241
q2	2039	178	165	165
q3	10585	1087	1177	1087
q4	10564	754	673	673
q5	7590	2735	2649	2649
q6	245	146	148	146
q7	976	621	609	609
q8	9245	1866	1940	1866
q9	6666	6545	6475	6475
q10	7010	2311	2316	2311
q11	456	271	262	262
q12	428	214	225	214
q13	17765	3002	3032	3002
q14	235	209	212	209
q15	567	526	522	522
q16	649	580	587	580
q17	969	593	547	547
q18	7167	6811	6654	6654
q19	1335	960	1011	960
q20	470	176	177	176
q21	4032	3257	3249	3249
q22	387	314	312	312
Total cold run time: 106969 ms
Total hot run time: 39909 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7223	7272	7211	7211
q2	329	226	230	226
q3	2882	3002	2914	2914
q4	2100	1800	1781	1781
q5	5744	5644	5624	5624
q6	226	147	143	143
q7	2285	1844	1819	1819
q8	3396	3551	3490	3490
q9	9021	9140	9108	9108
q10	3616	3521	3584	3521
q11	608	528	515	515
q12	816	614	624	614
q13	11383	3268	3197	3197
q14	314	282	289	282
q15	587	535	542	535
q16	676	648	658	648
q17	1875	1655	1638	1638
q18	8544	8053	7408	7408
q19	1756	1636	1595	1595
q20	2093	1890	1900	1890
q21	6007	5573	5567	5567
q22	615	565	625	565
Total cold run time: 72096 ms
Total hot run time: 60291 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198319 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e7310cc90e8326e5282a3157a3038a5999a77145, data reload: false

query1	1241	1003	952	952
query2	6241	2082	2086	2082
query3	10997	4389	4357	4357
query4	67024	28991	23648	23648
query5	4977	476	455	455
query6	413	185	181	181
query7	5578	302	296	296
query8	315	275	238	238
query9	8685	2728	2702	2702
query10	434	262	245	245
query11	17362	15333	16055	15333
query12	158	97	101	97
query13	1469	428	388	388
query14	12242	7886	7860	7860
query15	230	188	195	188
query16	6647	465	465	465
query17	1161	601	620	601
query18	992	338	311	311
query19	224	167	165	165
query20	121	116	114	114
query21	208	110	106	106
query22	4760	4627	4324	4324
query23	35138	34558	34512	34512
query24	5372	2548	2452	2452
query25	499	384	398	384
query26	652	152	151	151
query27	1828	287	284	284
query28	4579	2444	2497	2444
query29	664	445	418	418
query30	201	159	156	156
query31	1009	859	878	859
query32	64	55	54	54
query33	428	313	290	290
query34	939	512	530	512
query35	909	804	761	761
query36	1103	984	966	966
query37	125	72	82	72
query38	4370	4484	4339	4339
query39	1537	1490	1474	1474
query40	193	103	110	103
query41	47	43	47	43
query42	117	105	99	99
query43	550	503	500	500
query44	1196	836	826	826
query45	199	176	175	175
query46	1185	732	730	730
query47	2009	1960	1876	1876
query48	437	325	315	315
query49	728	390	414	390
query50	841	393	413	393
query51	7429	7136	7118	7118
query52	102	86	87	86
query53	256	174	188	174
query54	512	406	406	406
query55	81	75	72	72
query56	244	230	237	230
query57	1229	1117	1156	1117
query58	213	213	237	213
query59	3289	3060	2961	2961
query60	265	242	247	242
query61	106	104	110	104
query62	775	679	675	675
query63	218	191	191	191
query64	1356	665	625	625
query65	3304	3210	3191	3191
query66	623	305	297	297
query67	16251	15720	15790	15720
query68	3906	588	572	572
query69	438	261	241	241
query70	1203	1126	1163	1126
query71	327	252	248	248
query72	6459	4123	4140	4123
query73	760	362	381	362
query74	10349	8974	9054	8974
query75	3411	2713	2655	2655
query76	1772	1141	1147	1141
query77	482	279	279	279
query78	10529	9377	9356	9356
query79	1611	603	589	589
query80	887	427	437	427
query81	511	235	239	235
query82	1347	123	121	121
query83	251	146	143	143
query84	331	71	78	71
query85	914	298	294	294
query86	332	297	274	274
query87	4872	4847	4641	4641
query88	3541	2221	2196	2196
query89	420	306	284	284
query90	1995	190	185	185
query91	142	102	103	102
query92	67	49	49	49
query93	1927	543	548	543
query94	790	289	294	289
query95	347	239	250	239
query96	611	272	280	272
query97	2843	2668	2693	2668
query98	225	198	200	198
query99	1633	1334	1314	1314
Total cold run time: 319884 ms
Total hot run time: 198319 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e7310cc90e8326e5282a3157a3038a5999a77145, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.03	0.03
query3	0.23	0.08	0.06
query4	1.63	0.11	0.10
query5	0.42	0.40	0.39
query6	1.16	0.66	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.57	0.53	0.51
query10	0.55	0.56	0.56
query11	0.13	0.10	0.10
query12	0.13	0.11	0.11
query13	0.62	0.60	0.60
query14	2.84	2.74	2.75
query15	0.90	0.83	0.84
query16	0.36	0.38	0.37
query17	1.05	1.06	1.06
query18	0.22	0.21	0.20
query19	1.93	1.79	2.02
query20	0.02	0.01	0.01
query21	15.38	0.59	0.60
query22	2.54	2.84	2.56
query23	16.91	1.08	0.84
query24	3.18	1.06	1.75
query25	0.14	0.18	0.13
query26	0.61	0.14	0.13
query27	0.04	0.04	0.05
query28	9.94	1.12	1.09
query29	12.54	3.24	3.21
query30	0.25	0.07	0.06
query31	2.87	0.39	0.39
query32	3.27	0.46	0.46
query33	2.98	3.05	3.08
query34	16.87	4.45	4.50
query35	4.51	4.46	4.53
query36	0.65	0.49	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.04
query39	0.04	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.02	0.03
Total cold run time: 106.1 s
Total hot run time: 33.5 s

Copy link
Contributor

github-actions bot commented Dec 2, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 334b343 into apache:master Dec 2, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement CreateEncryptKeyCommand in nereids
4 participants