Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](nereids) not rewrite first_value when first_value ignore nulls #45065 #45235

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #45065

…45065)

this pr fix 2 things:
1.when first_value/last_value second parameter is true, which means
ignore nulls, fe should not do some rewrite.
2.adding check that first_value/last_value second parameter must be true
or false.

Related PR: #44996 #27623
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 10, 2024
@doris-robot
Copy link

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40647 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9ff77082c6ad62af59b9684dbb0febe8aa318f27, data reload: false

------ Round 1 ----------------------------------
q1	17581	7355	7302	7302
q2	2044	161	156	156
q3	10726	1076	1143	1076
q4	10554	752	752	752
q5	7755	2843	2799	2799
q6	235	148	146	146
q7	968	609	601	601
q8	9580	1965	1992	1965
q9	7718	6396	6402	6396
q10	7016	2300	2284	2284
q11	459	260	263	260
q12	413	212	211	211
q13	17763	2991	2997	2991
q14	240	216	219	216
q15	562	528	517	517
q16	673	594	622	594
q17	987	636	609	609
q18	7299	6530	6436	6436
q19	1380	1129	1050	1050
q20	454	209	203	203
q21	3955	3295	3107	3107
q22	1120	976	985	976
Total cold run time: 109482 ms
Total hot run time: 40647 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7272	7202	7205	7202
q2	322	236	227	227
q3	2911	2873	2893	2873
q4	2056	1793	1772	1772
q5	5684	5722	5756	5722
q6	226	146	146	146
q7	2193	1787	1830	1787
q8	3297	3553	3428	3428
q9	8931	8916	8903	8903
q10	3549	3547	3505	3505
q11	603	498	497	497
q12	803	619	599	599
q13	16488	3121	3101	3101
q14	316	270	279	270
q15	573	533	517	517
q16	686	659	657	657
q17	1864	1656	1585	1585
q18	8396	7795	7455	7455
q19	6371	1583	1473	1473
q20	2063	1863	1838	1838
q21	5532	5368	5263	5263
q22	1164	1038	1007	1007
Total cold run time: 81300 ms
Total hot run time: 59827 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195886 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9ff77082c6ad62af59b9684dbb0febe8aa318f27, data reload: false

query1	1247	923	906	906
query2	6267	2052	2034	2034
query3	10936	4159	4096	4096
query4	66713	30274	23509	23509
query5	5448	444	430	430
query6	466	171	159	159
query7	5862	313	309	309
query8	316	232	236	232
query9	9406	2740	2692	2692
query10	515	269	263	263
query11	17850	15284	15766	15284
query12	160	105	103	103
query13	1543	445	435	435
query14	11129	7116	7147	7116
query15	207	179	190	179
query16	6915	477	453	453
query17	1408	598	580	580
query18	1798	335	321	321
query19	232	158	165	158
query20	123	113	111	111
query21	69	44	49	44
query22	4451	4619	4310	4310
query23	34664	33991	34111	33991
query24	5971	2859	2958	2859
query25	526	390	392	390
query26	684	168	160	160
query27	1950	289	295	289
query28	4586	2528	2541	2528
query29	666	462	427	427
query30	248	166	162	162
query31	1013	810	820	810
query32	66	57	54	54
query33	413	285	287	285
query34	913	491	498	491
query35	822	732	728	728
query36	1068	946	956	946
query37	114	70	74	70
query38	4080	4035	3971	3971
query39	1525	1484	1463	1463
query40	136	83	90	83
query41	56	53	46	46
query42	106	99	98	98
query43	536	492	487	487
query44	1176	813	807	807
query45	186	165	171	165
query46	1144	728	735	728
query47	1975	1902	1943	1902
query48	456	356	364	356
query49	729	375	385	375
query50	836	428	422	422
query51	7285	7252	7067	7067
query52	98	85	81	81
query53	260	178	181	178
query54	561	447	444	444
query55	75	72	71	71
query56	259	230	239	230
query57	1170	1099	1094	1094
query58	202	205	204	204
query59	3139	2883	2823	2823
query60	272	249	253	249
query61	109	106	107	106
query62	765	662	646	646
query63	207	185	189	185
query64	1524	663	632	632
query65	3250	3173	3161	3161
query66	729	312	297	297
query67	15972	15366	15429	15366
query68	4557	570	554	554
query69	410	254	260	254
query70	1196	1066	1103	1066
query71	335	252	263	252
query72	6551	4121	4041	4041
query73	747	344	347	344
query74	10138	9018	8948	8948
query75	3376	2647	2655	2647
query76	1953	1130	998	998
query77	517	277	272	272
query78	10660	9654	9488	9488
query79	8642	599	597	597
query80	2407	483	414	414
query81	555	242	239	239
query82	1034	119	114	114
query83	301	147	141	141
query84	287	78	81	78
query85	1777	302	292	292
query86	491	265	301	265
query87	4445	4425	4192	4192
query88	5664	2373	2380	2373
query89	548	289	293	289
query90	2090	181	188	181
query91	176	144	167	144
query92	69	46	49	46
query93	6775	554	535	535
query94	980	298	296	296
query95	347	256	252	252
query96	623	278	285	278
query97	3339	3177	3163	3163
query98	215	198	192	192
query99	1598	1311	1290	1290
Total cold run time: 338386 ms
Total hot run time: 195886 ms

@feiniaofeiafei
Copy link
Contributor

run feut

@feiniaofeiafei
Copy link
Contributor

run p0

@zhangstar333 zhangstar333 merged commit c48d7f9 into branch-3.0 Dec 16, 2024
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-45065-branch-3.0 branch December 16, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants