Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvemment](profile) use one counter to represent MemoryUsage and MemoryUsagePeak (#44645) #46924

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

jacktengg
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: BP #44645

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@jacktengg
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41442 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cd5a9a88e642524a1435c9daaeeb0dbc388abc46, data reload: false

------ Round 1 ----------------------------------
q1	17625	7501	7275	7275
q2	2045	169	185	169
q3	10638	1169	1194	1169
q4	10569	787	767	767
q5	8881	3671	2926	2926
q6	244	150	153	150
q7	991	621	640	621
q8	9781	2035	2067	2035
q9	6794	6504	6516	6504
q10	8197	2293	2324	2293
q11	470	271	270	270
q12	402	222	211	211
q13	17797	3020	3024	3020
q14	230	213	218	213
q15	576	524	517	517
q16	711	616	624	616
q17	1006	542	533	533
q18	7410	6651	6716	6651
q19	1391	1117	998	998
q20	484	209	204	204
q21	4093	3405	3317	3317
q22	1116	983	994	983
Total cold run time: 111451 ms
Total hot run time: 41442 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7317	7261	7313	7261
q2	348	244	244	244
q3	3088	3036	2915	2915
q4	2094	1786	1781	1781
q5	5688	5844	5802	5802
q6	228	145	145	145
q7	2210	1715	1760	1715
q8	3413	3529	3504	3504
q9	8982	8848	8910	8848
q10	3605	3634	3520	3520
q11	597	498	500	498
q12	839	633	613	613
q13	4853	3201	3198	3198
q14	297	273	278	273
q15	574	514	531	514
q16	721	656	665	656
q17	1849	1645	1624	1624
q18	8271	7578	7574	7574
q19	1692	1685	1581	1581
q20	2091	1888	1868	1868
q21	5598	5312	5422	5312
q22	1114	1042	1026	1026
Total cold run time: 65469 ms
Total hot run time: 60472 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196852 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cd5a9a88e642524a1435c9daaeeb0dbc388abc46, data reload: false

query1	1242	922	931	922
query2	6259	2054	1982	1982
query3	10871	4403	4108	4108
query4	65786	29098	23560	23560
query5	4909	459	480	459
query6	425	200	186	186
query7	5639	327	316	316
query8	323	229	239	229
query9	9442	2686	2679	2679
query10	496	264	262	262
query11	17472	15157	15722	15157
query12	168	105	103	103
query13	1594	456	445	445
query14	9834	7502	7157	7157
query15	212	188	191	188
query16	7111	470	527	470
query17	1065	621	608	608
query18	1895	324	334	324
query19	233	170	157	157
query20	122	108	107	107
query21	210	104	113	104
query22	4758	4462	4419	4419
query23	34666	34363	34256	34256
query24	6176	2882	2924	2882
query25	512	398	408	398
query26	656	169	168	168
query27	1887	356	351	351
query28	4452	2488	2488	2488
query29	695	446	435	435
query30	235	157	159	157
query31	969	781	805	781
query32	66	55	61	55
query33	390	273	287	273
query34	889	483	503	483
query35	832	721	704	704
query36	1071	944	965	944
query37	119	73	72	72
query38	3929	3909	3827	3827
query39	1488	1437	1434	1434
query40	200	97	95	95
query41	47	46	46	46
query42	112	98	99	98
query43	526	482	472	472
query44	1152	812	806	806
query45	177	167	164	164
query46	1129	701	719	701
query47	1929	1828	1833	1828
query48	479	392	392	392
query49	722	379	380	379
query50	830	412	432	412
query51	7242	7121	6961	6961
query52	97	91	91	91
query53	258	181	181	181
query54	566	466	461	461
query55	76	77	75	75
query56	263	230	250	230
query57	1224	1078	1105	1078
query58	213	198	207	198
query59	3196	3075	2927	2927
query60	278	255	260	255
query61	125	110	107	107
query62	777	653	679	653
query63	224	186	198	186
query64	1385	697	654	654
query65	3256	3186	3238	3186
query66	640	314	306	306
query67	15950	15660	15599	15599
query68	2947	592	598	592
query69	421	271	264	264
query70	1143	1169	1114	1114
query71	336	257	274	257
query72	6153	4012	4105	4012
query73	749	349	348	348
query74	9966	8966	8940	8940
query75	3329	2661	2666	2661
query76	1584	993	1008	993
query77	500	283	284	283
query78	10459	9519	9627	9519
query79	1467	586	618	586
query80	869	436	431	431
query81	501	241	240	240
query82	1263	116	118	116
query83	185	145	147	145
query84	284	78	81	78
query85	891	318	352	318
query86	352	314	301	301
query87	4380	4491	4336	4336
query88	3745	2404	2389	2389
query89	419	296	298	296
query90	2030	189	191	189
query91	203	199	148	148
query92	63	49	51	49
query93	1829	556	557	556
query94	809	299	304	299
query95	357	259	263	259
query96	617	285	279	279
query97	3383	3167	3195	3167
query98	215	211	212	211
query99	1570	1289	1285	1285
Total cold run time: 315190 ms
Total hot run time: 196852 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.98 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cd5a9a88e642524a1435c9daaeeb0dbc388abc46, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.24	0.06	0.07
query4	1.61	0.10	0.10
query5	0.54	0.51	0.53
query6	1.13	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.02
query9	0.59	0.49	0.50
query10	0.54	0.55	0.57
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.60	0.60	0.58
query14	3.02	2.96	3.00
query15	0.90	0.82	0.82
query16	0.37	0.37	0.38
query17	1.05	1.05	1.01
query18	0.24	0.22	0.22
query19	2.02	1.95	1.97
query20	0.01	0.01	0.01
query21	15.38	0.58	0.58
query22	2.51	2.11	2.08
query23	17.05	0.95	0.80
query24	2.92	0.71	1.06
query25	0.14	0.12	0.06
query26	0.48	0.13	0.14
query27	0.05	0.04	0.04
query28	11.05	1.11	1.07
query29	12.59	3.27	3.25
query30	0.25	0.06	0.06
query31	2.88	0.40	0.38
query32	3.23	0.46	0.46
query33	3.00	2.98	3.05
query34	16.87	4.48	4.50
query35	4.51	4.45	4.49
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.18	0.13	0.13
query41	0.09	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.38 s
Total hot run time: 32.98 s

@jacktengg
Copy link
Contributor Author

run external

@yiguolei yiguolei merged commit 71b35a6 into apache:branch-3.0 Jan 14, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants