From d11fe3910042ed52aac29d142f18cdaf6d6c2414 Mon Sep 17 00:00:00 2001
From: eldenmoon <lihangyu@selectdb.com>
Date: Sat, 16 Nov 2024 19:40:31 +0800
Subject: [PATCH] [Fix](ShortCircuit) fix open segments leading to bad
 performace

Need need to open segments for all rowsets, only open in `lookup_row_key` stage.

Introduced by #42697
---
 be/src/service/point_query_executor.cpp | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/be/src/service/point_query_executor.cpp b/be/src/service/point_query_executor.cpp
index 74dab466340330..ea991e158a1138 100644
--- a/be/src/service/point_query_executor.cpp
+++ b/be/src/service/point_query_executor.cpp
@@ -396,17 +396,6 @@ Status PointQueryExecutor::_lookup_row_key() {
         specified_rowsets = _tablet->get_rowset_by_ids(nullptr);
     }
     std::vector<std::unique_ptr<SegmentCacheHandle>> segment_caches(specified_rowsets.size());
-    // init segment_cache
-    {
-        SCOPED_TIMER(&_profile_metrics.load_segment_key_stage_ns);
-        for (size_t i = 0; i < specified_rowsets.size(); i++) {
-            auto& rs = specified_rowsets[i];
-            segment_caches[i] = std::make_unique<SegmentCacheHandle>();
-            RETURN_IF_ERROR(SegmentLoader::instance()->load_segments(
-                    std::static_pointer_cast<BetaRowset>(rs), segment_caches[i].get(), true, true,
-                    &_profile_metrics.read_stats));
-        }
-    }
     for (size_t i = 0; i < _row_read_ctxs.size(); ++i) {
         RowLocation location;
         if (!config::disable_storage_row_cache) {