Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onhighlighted #420

Open
Jyyjy opened this issue Mar 16, 2024 · 2 comments
Open

onhighlighted #420

Jyyjy opened this issue Mar 16, 2024 · 2 comments

Comments

@Jyyjy
Copy link
Contributor

Jyyjy commented Mar 16, 2024

The only event from the tabs API that is not instrumented is onhighlighted. It is challenging to add at the moment because the event potentially applies to more than one tab.

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/Tabs/onHighlighted

@Suvendu-UI
Copy link
Contributor

So @Jyyjy can you elaborate the actual issue ?

@Jyyjy
Copy link
Contributor Author

Jyyjy commented Jul 24, 2024

// Attach Handlers for tab events

In background.ts, almost all events from the js tabs API are captured and logged. Except onhighlighted because onhighlighted is an event that happens to a list of tabs. Meanwhile other tab events only happen to a single tab.

The problem is that the functions expect an event to happen to a single tab. The two approaches to resolve it are to either create separate logs for each highlighted tab. Or put the information of all the tabs into a single log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants