Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error messages when creating a table with unsupported types #860

Open
vtk9 opened this issue Jun 26, 2024 · 7 comments · May be fixed by #1498
Open

Better error messages when creating a table with unsupported types #860

vtk9 opened this issue Jun 26, 2024 · 7 comments · May be fixed by #1498
Assignees
@DevChrisCross
Labels
good first issue Good for newcomers

Comments

@vtk9
Copy link

vtk9 commented Jun 26, 2024

Feature Request / Improvement

Related to #830 (reproducer included)

Creating a iceberg table using an arrow table that contains an unsupported type (such as date64). The resultant message is TypeError: Unsupported type: date64[ms]

It would be great if this error message also printed out the column name that has this unsupported type.

Even better, instead of raising a TypeError can a more specific error be returned (such as UnsupportedPyArrowType) which includes the pyarrow.Field (column_name, column_type) as an attribute so that this error can be caught and different exception re-raised based on information contained inside UnsupportedPyArrowType

For example, something like

try:
   ...
except UnsupportedPyArrowType as e:
   raise NewException(f"failure due to {e.field.name}")
@kevinjqliu
Copy link
Contributor

Heres the relevant code

iceberg-python/pyiceberg/io/pyarrow.py

Line 932 in a6cd0cf

raise TypeError(f"Unsupported type: {primitive}")

@kevinjqliu kevinjqliu added the good first issue Good for newcomers label Jun 26, 2024
@vivek378521
Copy link

vivek378521 commented Jul 1, 2024 •
edited
Loading

I want to work on this issue, but I cannot find a contributing-doc in the repo on how to set-up the project and run tests.

@kevinjqliu

@kevinjqliu
Copy link
Contributor

@vivek378521 The docs are located here.

https://py.iceberg.apache.org/contributing/
https://github.com/apache/iceberg-python/blob/main/mkdocs/docs/contributing.md

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

@github-actions github-actions bot added the stale label Dec 29, 2024
@kevinjqliu kevinjqliu removed the stale label Jan 3, 2025
@DevChrisCross
Copy link

Hi @kevinjqliu, I'm not sure if this issue is being worked on, in case not, can you assign it to me? :)

@kevinjqliu
Copy link
Contributor

@DevChrisCross assigned to you!

@DevChrisCross DevChrisCross linked a pull request Jan 8, 2025 that will close this issue
Open
@DevChrisCross
Copy link

@kevinjqliu @Fokko could you kindly check the PR please? Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DevChrisCross DevChrisCross

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modified exception objects being thrown when converting Pyarrow tables DevChrisCross/iceberg-python
4 participants
@vtk9 @kevinjqliu @DevChrisCross @vivek378521