Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-parser] Merge dev-new-parser to main #5988

Closed
tkobayas opened this issue Jun 11, 2024 · 1 comment
Closed

[new-parser] Merge dev-new-parser to main #5988

tkobayas opened this issue Jun 11, 2024 · 1 comment
Assignees

Comments

@tkobayas
Copy link
Contributor

tkobayas commented Jun 11, 2024

#5678 (comment)

As of 2024-07-11, dev-new-parser unit tests are all green. Remaining child issues are low priority, so they can be handled after merging to main.

The next step is to create a PR to merge dev-new-parser branch to main branch. Notes:

  • Merging has to be done after Drools 10.0 release 10.0.x is branched out.
  • Until the Drools 10.0 release, Until 10.0.x is branched out, mark the PR [DO-NOT-MERGE] and make it draft.
  • Create 2 PRs.
    • One makes the new parser not default parser. So it shouldn't affect the default behavior. It is the one to be merged. Make sure to use "Rebase and merge" (not "Squash and merge") in the Github UI to keep commit history.
    • The other makes the new parser default parser (with a system property switch). It is in order to check any regression error. It's not to be merged, so draft PR.
  • After Drools 10 release, discuss the future plan in dev at kie.apache ML.
  • Change sysout ### parse : ANTLR4_PARSER_ENABLED = to debug log
@tkobayas
Copy link
Contributor Author

Merged by #5989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎯 Done
Development

No branches or pull requests

1 participant