Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kogito-runtime-jvm to build in the same context as kogito-s2i #1721

Open
ricardozanini opened this issue Dec 27, 2023 · 2 comments
Open

Comments

@ricardozanini
Copy link
Member

The only problem left is the s2i builder tests that depends on quay.io/kiegroup/kogito-runtime-jvm:latest. Since now every build runs on its on context, we won't have access to this image from the s2i pipeline. The alternatives we have:

  1. Build the kogito-runtime-jvm together with the s2i pipeline.
  2. Share the context between kogito-runtime-jvm and s2i, or make them run in a single pipeline.

The nightly won't have problems since we should push the tags and the runtime runs before s2i.

We can merge this one if only s2i is failing in the tests in the behave depending on the runtime image. Then, we can fix this problem in a follow-up PR.

The quay.io/kiegroup/kogito-runtime-jvm:latest image is in Java 11, that's the reason you see the failures.

Originally posted by @ricardozanini in #1720 (comment)

@ricardozanini
Copy link
Member Author

cc @baldimir @jakubschwan

@jstastny-cz we need to handle this in some level of urgency if we expect to keep supporting the legacy Kogito Operator/RHPAM Operator builders.

I don't think it's critical, though. But it would be nice to have a feature to build images together/share the registry in the same runs.

@ricardozanini
Copy link
Member Author

This commit has all the ignored tests: 852de14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant