Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Fix requestShuffleAssignment in RssShuffleManagerBase #2153

Closed
3 tasks done
kuszz opened this issue Sep 27, 2024 · 0 comments · Fixed by #2138
Closed
3 tasks done

[Improvement] Fix requestShuffleAssignment in RssShuffleManagerBase #2153

kuszz opened this issue Sep 27, 2024 · 0 comments · Fixed by #2138

Comments

@kuszz
Copy link
Contributor

kuszz commented Sep 27, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

RssShuffleManagerBase.getShuffleAssignments and registerShuffleServers should in one retry

How should we improve?

Modify RssShuffleManagerBase, let getShuffleAssignments and registerShuffleServers in one retry, and fix some code style problem

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@kuszz kuszz mentioned this issue Sep 27, 2024
Merged
@jerqi jerqi closed this as completed in c5e20d8 Oct 17, 2024
maobaolong pushed a commit to maobaolong/incubator-uniffle that referenced this issue Nov 4, 2024
@maobaolong
TX: Combine [apache#2094] feat(client): Introduce retry mechanism for…
5ff3645 
… coordinator client (apache#2095) and [apache#2153] fix(client): Fix requestShuffleAssignment in RssShuffleManagerBase (apache#2138)

TAPD: --story=120236859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#2153] fix(client): Fix requestShuffleAssignment in RssShuffleManagerBase kuszz/incubator-uniffle
1 participant
@kuszz