Kyuubi Hive JDBC driver throws "Method Not Supported" on retrieving DATE data

[mahalingamagesthian]

We have been using Kyuubi on the Kubernetes environment for the last 8months in production. We are testing the integration of Tableau Desktop - Kyuubi. The integration uses kyuubi-hive-jdbc-shaded-1.7.0.jar. its configured as per Tableau documentation. Tableau Desktop - kyuubi jdbc connection is successful. We are able to retrive schemas/databases and their tables. When we view data: a table that contains date columns, we are getting

java.sql.SQLFeatureNotSupportedException: Method not supported
	at org.apache.kyuubi.jdbc.hive.adapter.SQLResultSet.getDate(SQLResultSet.java:441) ~[?:?]

This has been observed to be happening for ORC & Parquet formatted tables.

Reproduction Steps:

Create table test_datetime (
  cntr_id INT, cntr_date DATE) using orc location 's3a://bucketnamel/test_datetime'
INSERT Into table test_datetime select 1, current_date()
INSERT Into table test_datetime select 2, current_date()+1

Select * from test_datetime
+----------+-------------+
| cntr_id  |  cntr_date  |
+----------+-------------+
| 1        | 2023-11-08  |
| 2        | 2023-11-09  |
+----------+-------------+

When we preview the data from tableau using the jdbc driver, we run into the following exception on the Tableau Desktop:

Unable to complete action
Bad Connection: Tableau could not connect to the data source.
Error Code: FAB9A2C5
Method not supported
SELECT test_datetime.cntr_date AS cntr_date,
  test_datetime.cntr_id AS cntr_id
FROM <databasename>.test_datetime test_datetime
LIMIT 10000

Kyuubi driver log has the following exception:

2023-11-08 07:22:09.433 +0000 (,,,,4,66) grpc-default-executor-2 : ERROR com.tableau.connect.grpc.GrpcProtocolService - Failed in fetchResults. SQLState=null, ErrorCode=0.
java.sql.SQLFeatureNotSupportedException: Method not supported
        at org.apache.kyuubi.jdbc.hive.adapter.SQLResultSet.getDate(SQLResultSet.java:441) ~[?:?]
        at com.tableausoftware.data.ProtobufJDBCResultSet.addValue(ProtobufJDBCResultSet.java:519) ~[jdbcserver.jar:20232.0.5]
        at com.tableausoftware.data.ProtobufJDBCResultSet.addRow(ProtobufJDBCResultSet.java:420) ~[jdbcserver.jar:20232.0.5]
        at com.tableausoftware.data.ProtobufJDBCResultSet.fetchRows(ProtobufJDBCResultSet.java:240) ~[jdbcserver.jar:20232.0.5]
        at com.tableausoftware.data.ProtobufJDBCResultSet.nextBlockImpl(ProtobufJDBCResultSet.java:292) ~[jdbcserver.jar:20232.0.5]
        at com.tableausoftware.data.ProtobufResultSet.nextBlock(ProtobufResultSet.java:47) ~[jdbcserver.jar:20232.0.5]
        at com.tableau.connect.service.QueryTask.readData(QueryTask.java:130) ~[jdbcserver.jar:20232.0.5]
        at com.tableau.connect.service.QueryTask.call(QueryTask.java:91) ~[jdbcserver.jar:20232.0.5]
        at com.tableau.connect.service.QueryTask.call(QueryTask.java:41) ~[jdbcserver.jar:20232.0.5]
        at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) ~[?:?]
        at java.lang.Thread.run(Unknown Source) ~[?:?]

_Have someone faced this issue before ? Are there any leads/workarounds available to this problem? _

[pan3793]

Thanks for reporting this issue. The error message is clear enough to identify the root cause, it's because Kyuubi does not implement the following JDBC methods.

PS: it's common that JDBC driver vendors to only implement some of the JDBC interface methods, the caller(in this case, Tableau) usually takes care of SQLFeatureNotSupportedException and fallback to invoke another method, so I would not say this is a bug, but we can improve it in Kyuubi JDBC driver side to implement more methods.

public interface ResultSet extends Wrapper, AutoCloseable {
    ...

    /**
     * Retrieves the value of the designated column in the current row
     * of this <code>ResultSet</code> object as a <code>java.sql.Date</code> object
     * in the Java programming language.
     * This method uses the given calendar to construct an appropriate millisecond
     * value for the date if the underlying database does not store
     * timezone information.
     *
     * @param columnIndex the first column is 1, the second is 2, ...
     * @param cal the <code>java.util.Calendar</code> object
     * to use in constructing the date
     * @return the column value as a <code>java.sql.Date</code> object;
     * if the value is SQL <code>NULL</code>,
     * the value returned is <code>null</code> in the Java programming language
     * @exception SQLException if the columnIndex is not valid;
     * if a database access error occurs
     * or this method is called on a closed result set
     * @since 1.2
     */
    java.sql.Date getDate(int columnIndex, Calendar cal) throws SQLException;

    ...
}

[mahalingamagesthian]

Thanks @pan3793

[zhaohehuhu]

@mahalingamagesthian I almost finish this feature, but I don't have a Tableau Desktop in hand. Could you plz do me a favour to test this feature?

[mahalingamagesthian]

@zhaohehuhu - I have picked this one for testing, I will keep you posted on the testing results.

[zhaohehuhu]

OK. plz pick this pr #5752. Thanks @mahalingamagesthian

[mahalingamagesthian]

@zhaohehuhu , @pan3793 - I have tested the fix. It works. The testing scoped to view

1. Date column
2. Date with timestamp column
3. Date with timestamp column & spark.sql.session.timeZone property

using the new kyuubi-hive-jdbc-shaded-1.9.0-SNAPSHOT.jar built using latest commit , Tableau Desktop was able to render the data without errors.

[zhaohehuhu]

Thanks @mahalingamagesthian . I appreciate it.

[pan3793]

Thanks to @zhaohehuhu for addressing this issue and @mahalingamagesthian for confirming. This patch will be included in the next versions 1.9.0/1.8.1