Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to new Usages preview panel (NB24) #8068

Open
jjazzboss opened this issue Dec 17, 2024 · 4 comments · May be fixed by #8089
Open

Minor improvements to new Usages preview panel (NB24) #8068

jjazzboss opened this issue Dec 17, 2024 · 4 comments · May be fixed by #8089
Labels
kind:feature A feature request UI User Interface

Comments

@jjazzboss
Copy link
Contributor

jjazzboss commented Dec 17, 2024 •
edited
Loading

Description

Attached image is what I get with Usages. I can't read the beginning of left panel so each time (except if the first usage line found is short) I have to scroll on the left.
2024-12-17 20_55_00-MusicControl - Apache NetBeans IDE 24

Use case/motivation

Scrollbar of the left panel should be forced to the left.
Horizontal split position between left/right usage panels should be saved and reused for next Usages.

Related issues

No response

Are you willing to submit a pull request?

No
@jjazzboss jjazzboss added kind:feature A feature request needs:triage Requires attention from one of the committers labels Dec 17, 2024
@mbien mbien added UI User Interface and removed needs:triage Requires attention from one of the committers labels Dec 17, 2024
@mbien
Copy link
Member

mbien commented Dec 18, 2024

this is behavior is shared between all trees. The scrollpane will try to keep the node in the viewport if the selection changes.

The reason why it is more noticeable in the usages window is likely because the nodes can contain longer lines, this pretty much guarantees that the viewport moves if the selection changes.

I can reproduce the same behavior in the projects tree or refactoring preview window etc. I am sure we can come up with something but we have to be careful to not introduce other bugs.

@jjazzboss
Copy link
Contributor Author

jjazzboss commented Dec 18, 2024 •
edited
Loading

If it's easier, just saving the split position and reuse it could be another way to solve this. It might seem a minor thing, but doing 30 times scroll+move split bar is really irritating at the end...

@mbien
Copy link
Member

mbien commented Dec 18, 2024

yeah, UI persistence for the find-usages splitter needs to be implemented. The search results window #7779 does have it but we overlooked it for find-usages #7694.

@mbien mbien linked a pull request Dec 23, 2024 that will close this issue
Open
@mbien
Copy link
Member

mbien commented Dec 23, 2024 •
edited
Loading

@jjazzboss implemented the tree navigation change in #8089, dev-build for testing purposes is here: https://github.com/apache/netbeans/actions/runs/12474234603/artifacts/2357632475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:feature A feature request UI User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve refactoring preview divider handling and tree navigation. mbien/netbeans
2 participants
@mbien @jjazzboss