Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Presign Google Urls #1184

Closed
baszalmstra opened this issue Jan 13, 2023 · 7 comments
Closed

Feature request: Presign Google Urls #1184

baszalmstra opened this issue Jan 13, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@baszalmstra
Copy link
Contributor

I noticed that the GCS backend is missing pre signing URLs. I think it should be relatively trivial to add with reqsign already being used there. I'll get around to making a PR at some point, but I thought Id already leave an issue here for future reference.

@Xuanwo
Copy link
Member

Xuanwo commented Jan 16, 2023

Sounds great!

But presign google URLs is a bit more complex than expected. The current signing logic uses google's JSON API along with OAuth2 Token which can't do presign. We need to add V4 API support which silimiar to AWS Sigv4: https://cloud.google.com/storage/docs/access-control/signed-urls

@wolfv
Copy link

wolfv commented Jan 26, 2023

I think the algorithm is pretty much exactly like AWS V4. The official docs have an example that uses RSA-SHA256 for signing, but HMAC-SHA256 seems also available (https://cloud.google.com/storage/docs/authentication/signatures) which means that no additional dependencies should be needed.

I've started to copy over the aws v4 file and tried to make the adjustments for google::v4 but haven't tackled the config loader part yet :)

@Xuanwo Xuanwo added the enhancement New feature or request label Jan 26, 2023
@Xuanwo
Copy link
Member

Xuanwo commented Jan 26, 2023

I have assign this issue to @wolfv & @baszalmstra. Any problems you encounter can be communicated here and I am willing to help ❤️

@Xuanwo
Copy link
Member

Xuanwo commented Apr 26, 2023

Hi, @wolfv & @baszalmstra, presign support for gcs has been added now! Are you still willing to use this feature?

@Xuanwo Xuanwo closed this as completed Apr 26, 2023
@wolfv
Copy link

wolfv commented Apr 26, 2023

We are definitely using this feature :) thanks!

One other feature we've been looking for is the ability to attach arbitrary metadata to files. Are there plans for that?

@Xuanwo
Copy link
Member

Xuanwo commented Apr 26, 2023

One other feature we've been looking for is the ability to attach arbitrary metadata to files. Are there plans for that?

Are you talking about #2013?

@wolfv
Copy link

wolfv commented Apr 26, 2023

yes, exactly! Hadn't seen that issue a couple weeks ago! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants