New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: UB inside `opendal_compat` #5239

Open

1 task

Xuanwo opened this issue Oct 24, 2024 · 0 comments

Labels

bug

Member

Xuanwo commented Oct 24, 2024

Describe the bug

opendal_compat depends on transmute to perform conver between structs.

But based on discussion happened at https://rust-lang.github.io/unsafe-code-guidelines/layout/structs-and-tuples.html and https://www.notion.so/xuanwospace/Inbox-1185e01178f980a3b7fadc9d0c1b54d2?pvs=4#1295e01178f9802f8c0fdc38c2b2fcae

It's really UB and results many unexplained bug. It's better to remove all transmute and replace with from/into.

Steps to Reproduce

Perform list over opendal_v0_49

Expected Behavior

All operations should work as expected.

Additional Context

No response

Are you willing to submit a PR to fix this bug?

Yes, I would like to submit a PR.

The text was updated successfully, but these errors were encountered:

Xuanwo added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment