Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix playground NullPointerException #530

Merged
merged 7 commits into from
Aug 16, 2024
Merged

[Bugfix] Fix playground NullPointerException #530

merged 7 commits into from
Aug 16, 2024

Conversation

hiliuxg
Copy link
Contributor

@hiliuxg hiliuxg commented Aug 15, 2024 •
edited by SteNicholas
Loading

Purpose

Fix #531.

  1. Fix playground npe bug
  2. Fix render nothing where run "show tables" sql

Tests

  1. Run a one-liner command, for example, to register a catalog, set a variable, and suppress the output.
    image
  2. Run a multi-liner command, for example, to register a catalog, set a variable, get metadata
    image
  3. Run one-liner command to get data result
    image
  4. Run multi-liner command to get data result
    image
  5. Run error sql
    image

API and Format

Documentation

hiliuxg added 5 commits August 15, 2024 15:18
1. fix playground npe bug
6e1d728 
2. fix render nothing where run "show tables" sql
1. fix playground npe bug
5d3b252 
2. fix render nothing where run "show tables" sql
1. fix playground npe bug
cf057e9 
2. fix render nothing where run "show tables" sql
1. fix playground npe bug
546e4a1 
2. fix render nothing where run "show tables" sql
1. fix playground npe bug
068cacf 
2. fix render nothing where run "show tables" sql
@SteNicholas SteNicholas changed the title [Bugfix]fix playground npe bug [Bugfix] Fix playground NullPointerException Aug 16, 2024
@hiliuxg hiliuxg mentioned this pull request Aug 16, 2024
Closed
2 tasks
hiliuxg added 2 commits August 16, 2024 15:18
1. fix playground npe bug
572cd4d 
2. fix render nothing where run "show tables" sql
1. fix playground npe bug
4b8335a 
2. fix render nothing where run "show tables" sql
SteNicholas
SteNicholas approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SteNicholas SteNicholas merged commit d7a3813 into apache:main Aug 16, 2024
3 checks passed
SteNicholas pushed a commit that referenced this pull request Sep 9, 2024
@hiliuxg @SteNicholas
[Bugfix] Fix playground NullPointerException (#530)
5d1fea3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteNicholas SteNicholas SteNicholas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]playground NullPointerException
2 participants
@hiliuxg @SteNicholas