Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Replace AkkaParadoxPlugin with PekkoParadoxPlugin #12

Closed
wants to merge 1 commit into from

Conversation

reypader
Copy link
Contributor

Fixes #11

@reypader
Copy link
Contributor Author

Base template applies but subpages lose the pekko logo and the header is blue. Still trying to figure out why

@@ -1,6 +1,7 @@
addSbtPlugin("com.lightbend.akka" % "sbt-paradox-akka" % "0.44")
addSbtPlugin("org.apache.pekko" % "pekko-sbt-paradox" % "0.0.0+55-2e9e22a8-SNAPSHOT") // #TODO: user release version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjfanning
Copy link
Contributor

@reypader applying this is actually hard. I didn't raise this and expect you to do it. Someone who has done it before will find this much easier. As well as the plugin.sbt issue I already raised, there are quite a lot of settings in incubator-pekko project/Paradox.scala that need to be copied over - the pekkoThemeSettings and those settings need to be wired into the project settings.

I can have a look at this myself in a few days.

@reypader
Copy link
Contributor Author

reypader commented Jul 18, 2023

@pjfanning thanks for the heads up! I'll close this ticket now. Looking at it upfront, it seemed easy enough 😆 .

...there are quite a lot of settings in incubator-pekko project/Paradox.scala that need to be copied over - the pekkoThemeSettings and those settings need to be wired into the project settings

I was actually staring at this class as well and half considered copying it over!

@reypader reypader closed this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change docs to use pekko paradox plugin
2 participants