-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #480
base: trunk
Are you sure you want to change the base?
Spelling #480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the changes were automatically suggested by Google Sheets. A large portion of them were me applying other corrections or manually applying corrections. All fault mine.
// gradles gradle-worker.jar is still not a JPMS module and thus runs as unnamed module | ||
// gradle's gradle-worker.jar is still not a JPMS module and thus runs as unnamed module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brand
build.gradle
Outdated
// Some additional properties are currently set in the Jenkins-DSL, see jenksin/create_jobs.groovy | ||
// Some additional properties are currently set in the Jenkins-DSL, see jenkins/create_jobs.groovy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brand
<echo file="download-snipplet.xml"><![CDATA[ | ||
<echo file="download-snippet.xml"><![CDATA[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dunno if something cares about the filename...
LOG.atError().withThrowable(e).log("Batik is not not added to/working on the module-path. Use classpath mode instead of JPMS. Fallback to PNG."); | ||
LOG.atError().withThrowable(e).log("Batik is not added to/working on the module-path. Use classpath mode instead of JPMS. Fallback to PNG."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doubled words have been historically flagged by spell checking tools... doubled negatives are problematic...
graphicFrame.setName("Diagramm" + frameId); | ||
graphicFrame.setName("Diagram" + frameId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this an api break?
poi/src/test/java/org/apache/poi/hssf/usermodel/TestHSSFSheet.java
Outdated
Show resolved
Hide resolved
"SecurityManager does not work any more since JDK 18"); | ||
"SecurityManager does not work since JDK 18"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in principle, this should be anymore
, but in practice, it's superfluous, so I removed it.
* not not issue an EOF when we discover the last block | ||
* not to issue an EOF when we discover the last block |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or to not
, but I think this is the right change...
poi/src/test/java/org/apache/poi/ss/formula/atp/TestWorkdayFunction.java
Outdated
Show resolved
Hide resolved
// that that is now used if no policy given | ||
// that it is now used if no policy given |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atypical correction
poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFRun.java
Outdated
Show resolved
Hide resolved
014c79e
to
5fa0530
Compare
assertEquals("Sheet1\nI have lots of embeded files in me\nSheet2\nSheet3\n", ex.getText()); /* fixing the spelling here requires editing 44643.xls */ | ||
assertEquals("Excel With Embeded", ex.getSummaryInformation().getTitle()); /* fixing the spelling here requires editing 44643.xls */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving these here. I'm not sure I have access to the right version of Excel to update the files. But I suspect that the rest of the changes for this commit are ok.
It's possible everything else is ok. I'm done for the weekend. I'll check back sometime next week. Thanks for the prompt response. I should have looked at the workflows more carefully, I missed that there was a |
I've currently dropped |
I can't figure out where the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 from me
- PR is much too big
- changes data used in tests that can break tests
- changes file names
- changes API - we can't just remove a rename a public method - we need to deprecate it and add a new method with the corrected name - mark deprecations and
since
flags
I've applied a few low risk changes. It is not a priority for me to keep applying more.
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Thanks, I'm happy to split out other pieces, e.g. perhaps things that don't rename files / apis / test data... |
Thanks @jsoref - I'm not 100% sure this is worth the effort. This is not even a live repo - the real code is in a subversion repo. So applying PRs to our code is very manual and time consuming. Over time, I can come back to this PR and grab a couple more changes and apply them myself. |
Yeah, I noticed the svn bits. Anyway, thanks for working on this and the project in general. My employer uses this library :) |
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/poi/actions/runs/5360105495#summary-14513021500
The action reports that the changes in this PR would make it happy: https://github.com/check-spelling/poi/actions/runs/5360101471#summary-14513009039