From 2152ae8c21d1a3ce232c04c5a2c6ccd72bfe9204 Mon Sep 17 00:00:00 2001
From: asapple <960099622@qq.com>
Date: Tue, 10 Dec 2024 17:14:33 +0800
Subject: [PATCH] Optimize shouldUpdateAddressList method using containsAll

---
 .../rocketmq/remoting/netty/NettyRemotingClient.java      | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
index 609f59ac95d..8179341d80c 100644
--- a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
+++ b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
@@ -526,13 +526,7 @@ private static boolean shouldUpdateAddressList(List<String> newAddresses, List<S
             return true;
         }
 
-        for (String addr : newAddresses) {
-            if (!oldAddresses.contains(addr)) {
-                return true;
-            }
-        }
-
-        return false;
+        return !new HashSet<>(newAddresses).containsAll(oldAddresses);
     }
 
     /**