Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9059] Support reset offset for lite pull consumer #9060

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

humkum
Copy link
Contributor

@humkum humkum commented Dec 17, 2024

Which Issue(s) This PR Fixes

Fixes #9059

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.84%. Comparing base (93e2689) to head (650ab62).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...rocketmq/client/impl/factory/MQClientInstance.java 66.66% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9060      +/-   ##
=============================================
- Coverage      47.97%   47.84%   -0.14%     
+ Complexity     11904    11866      -38     
=============================================
  Files           1312     1312              
  Lines          91735    91751      +16     
  Branches       11751    11754       +3     
=============================================
- Hits           44014    43898     -116     
- Misses         42312    42429     +117     
- Partials        5409     5424      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@humkum humkum force-pushed the feat-reset-offset-lite-pull branch 3 times, most recently from 12491f3 to bd0a695 Compare December 18, 2024 02:55
@RongtongJin RongtongJin changed the title feat: support reset offset for lite pull consumer [ISSUE #9059] Support reset offset for lite pull consumer Dec 19, 2024
@RongtongJin
Copy link
Contributor

CI needs to be passed

@humkum humkum force-pushed the feat-reset-offset-lite-pull branch from bd0a695 to 650ab62 Compare December 19, 2024 12:28
@humkum
Copy link
Contributor Author

humkum commented Dec 20, 2024

CI needs to be passed

done,please help to review again~ @RongtongJin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] DefaultLitePullConsumer supports resetting consumer offset.
3 participants