Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not every ingress controller is nginx #725

Open
msporleder opened this issue Oct 10, 2024 · 1 comment
Open

not every ingress controller is nginx #725

msporleder opened this issue Oct 10, 2024 · 1 comment

Comments

@msporleder
Copy link

if solrNodesRequireTLS {
if annotations == nil {
annotations = make(map[string]string, 1)
}
_, ok := annotations["nginx.ingress.kubernetes.io/backend-protocol"]
if !ok {
annotations["nginx.ingress.kubernetes.io/backend-protocol"] = "HTTPS"
}
} else {
if annotations == nil {
annotations = make(map[string]string, 1)
}
_, ok := annotations["nginx.ingress.kubernetes.io/backend-protocol"]
if !ok {
annotations["nginx.ingress.kubernetes.io/backend-protocol"] = "HTTP"
}
}

Although this is pretty harmless as noise I'm not sure why this assumption was hard-coded in.

Can you consider adding if customOptions.IngressClassName == "nginx" or similar?

@gerlowskija
Copy link
Contributor

Agreed - it's likely not causing any harm, but it'd make sense to have this annotation be conditional on the actual Ingress controller in use.

If you're interested in opening a PR @msporleder, I'd be happy to review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants