From b3e45f7388d7da81f2a63f29e4c92812cd4b43a0 Mon Sep 17 00:00:00 2001
From: jdyer1 <jdyer@apache.org>
Date: Thu, 19 Dec 2024 09:22:29 -0600
Subject: [PATCH] Deprecate CloudHttp2SolrClient.Builder#withHttpClient

---
 solr/CHANGES.txt                                               | 3 ++-
 .../apache/solr/client/solrj/impl/CloudHttp2SolrClient.java    | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index 9b797e36b2b..04414674de6 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -11,7 +11,8 @@ New Features
 
 Improvements
 ---------------------
-(No changes)
+* SOLR-17541: Deprecate `CloudHttp2SolrClient.Builder#withHttpClient` in favor of
+  `CloudHttp2SolrClient.Builder#withInternalClientBuilder` (James Dyer)
 
 Optimizations
 ---------------------
diff --git a/solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java b/solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java
index 670bd2963ff..68abbc45be6 100644
--- a/solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java
+++ b/solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java
@@ -412,6 +412,8 @@ public Builder withCollectionCacheTtl(long timeToLive, TimeUnit unit) {
      *
      * @param httpClient http client
      * @return this
+     * 
+     * @deprecated Please use {@link #withInternalClientBuilder(Http2SolrClient.Builder)}
      */
     public Builder withHttpClient(Http2SolrClient httpClient) {
       if (this.internalClientBuilder != null) {