-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d3 formatting not working #7650
Comments
Issue-Label Bot is automatically applying the label Links: app homepage, dashboard and code for this bot. |
@kristw any ideas about how to fix this? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
@kristw |
FWIW, I managed to get D3 formatting to work in the Table component for other metrics besides COUNT(*) as you can see in this (admittedly odd looking) example: Nonetheless, I also see/confirm that this formatting value is not represented in the Pie chart (or probably other NVD3-derived chart types). |
@rusackas There is an incomplete PR, which maybe related, if anybody feels like picking up. |
PRs to respect the metrics' |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
Expected results
Number formatting on dashboard should change according to d3 format specified in metrics
Actual results
Specifying a d3 format works on the COUNT(*) metric. But has no affect on any other metric as far as I can tell
Screenshots
In the image above COUNT(*) and SUM(count) have the same d3 format configured. However, the configuration is not being applied to SUM(count)
How to reproduce the bug
Environment
*superset version: 0.33.0
*python version: 3.6.8
Checklist
Make sure these boxes are checked before submitting your issue - thank you!
Additional context
I have seen a number of other Issues raised around d3 formatting dating back to 2017. As far as I can tell those issues were fixed in this PR #2598
So I believe this must be a new bug
The text was updated successfully, but these errors were encountered: