From a474265921ee0b83f0fd31021cc5a7f976b60dad Mon Sep 17 00:00:00 2001 From: samraHanif0340 Date: Mon, 23 Dec 2024 17:04:59 +0500 Subject: [PATCH 1/2] feat: enabling selection of columns ad rows in sql lab and dataset view --- superset-frontend/src/components/Table/VirtualTable.tsx | 2 +- superset-frontend/src/components/Table/index.tsx | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/superset-frontend/src/components/Table/VirtualTable.tsx b/superset-frontend/src/components/Table/VirtualTable.tsx index 5b49a8f66b967..f05f81afede7c 100644 --- a/superset-frontend/src/components/Table/VirtualTable.tsx +++ b/superset-frontend/src/components/Table/VirtualTable.tsx @@ -53,7 +53,7 @@ const StyledTable = styled(AntTable)<{ height?: number }>( th.ant-table-cell { font-weight: ${theme.typography.weights.bold}; color: ${theme.colors.grayscale.dark1}; - user-select: none; + user-select: text; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; diff --git a/superset-frontend/src/components/Table/index.tsx b/superset-frontend/src/components/Table/index.tsx index dd3199f766d7b..589c79215688f 100644 --- a/superset-frontend/src/components/Table/index.tsx +++ b/superset-frontend/src/components/Table/index.tsx @@ -174,14 +174,14 @@ const StyledTable = styled(AntTable)<{ height?: number }>( th.ant-table-cell { font-weight: ${theme.typography.weights.bold}; color: ${theme.colors.grayscale.dark1}; - user-select: none; + user-select: text; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; } .ant-table-tbody > tr > td { - user-select: none; + user-select: text; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; From 692282e8fa8df70d1a2e970c8428155da2975b33 Mon Sep 17 00:00:00 2001 From: samraHanif0340 Date: Mon, 6 Jan 2025 21:34:51 +0500 Subject: [PATCH 2/2] fix: removed user-select as none for simplicity --- superset-frontend/src/components/Table/VirtualTable.tsx | 1 - superset-frontend/src/components/Table/index.tsx | 2 -- 2 files changed, 3 deletions(-) diff --git a/superset-frontend/src/components/Table/VirtualTable.tsx b/superset-frontend/src/components/Table/VirtualTable.tsx index f05f81afede7c..4eb4842e83843 100644 --- a/superset-frontend/src/components/Table/VirtualTable.tsx +++ b/superset-frontend/src/components/Table/VirtualTable.tsx @@ -53,7 +53,6 @@ const StyledTable = styled(AntTable)<{ height?: number }>( th.ant-table-cell { font-weight: ${theme.typography.weights.bold}; color: ${theme.colors.grayscale.dark1}; - user-select: text; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; diff --git a/superset-frontend/src/components/Table/index.tsx b/superset-frontend/src/components/Table/index.tsx index 589c79215688f..1495befa5acc9 100644 --- a/superset-frontend/src/components/Table/index.tsx +++ b/superset-frontend/src/components/Table/index.tsx @@ -174,14 +174,12 @@ const StyledTable = styled(AntTable)<{ height?: number }>( th.ant-table-cell { font-weight: ${theme.typography.weights.bold}; color: ${theme.colors.grayscale.dark1}; - user-select: text; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; } .ant-table-tbody > tr > td { - user-select: text; white-space: nowrap; overflow: hidden; text-overflow: ellipsis;