Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRONTEND][PYTORCH] Relay pytorch frontend does not support aten:scaled_dot_product_attention #15361

Closed
rebel-shshin opened this issue Jul 19, 2023 · 3 comments · Fixed by #16143
Closed

[FRONTEND][PYTORCH] Relay pytorch frontend does not support aten:scaled_dot_product_attention #15361

rebel-shshin opened this issue Jul 19, 2023 · 3 comments · Fixed by #16143
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug

Comments

@rebel-shshin
Copy link
Contributor

rebel-shshin commented Jul 19, 2023 •
edited by github-actions bot
Loading

Hi, I just wondering that is there any plan to support scaled_dot_product_attention OP which is included in pytorch2.0?

cc @shingjan @yelite
@rebel-shshin rebel-shshin added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug labels Jul 19, 2023
@rebel-shshin rebel-shshin changed the title [Bug] Relay pytorch frontend does not support aten:scaled_dot_product_attention Relay pytorch frontend does not support aten:scaled_dot_product_attention Jul 19, 2023
@rebel-shshin rebel-shshin changed the title Relay pytorch frontend does not support aten:scaled_dot_product_attention [FRONTEND][PYTORCH] Relay pytorch frontend does not support aten:scaled_dot_product_attention Jul 19, 2023
@denis-ismailaj denis-ismailaj mentioned this issue Sep 4, 2023
Closed
@mshr-h
Copy link
Contributor

mshr-h commented Nov 16, 2023

I'll try to work on it.

@mshr-h mshr-h mentioned this issue Nov 17, 2023
Merged
@mshr-h
Copy link
Contributor

mshr-h commented Nov 28, 2023

@rebel-shshin
The initial implementation is done. #16143
But haven't tested with the actual model.
Can you provide the script for CLIP model conversion if possible? #15663 (comment)

@rebel-shshin
Copy link
Contributor Author

Hi, @mshr-h. Thanks for the update. I test the CLIP model using HF stable diffusion, and confirmed the patch working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Relay][Pytorch] Add support for aten::scaled_dot_product_attention mshr-h/tvm
2 participants
@mshr-h @rebel-shshin