Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unity][nn.module] Rolling KVCache override method #16100

Closed
wants to merge 1 commit into from

Conversation

davidpissarra
Copy link
Contributor

Part of the effort in bringing Mistral to the compilation flow with nn.Module on mlc-llm. Adding support for Rolling KVCache override method in the nn.module frontend.

cc @CharlieFRuan

@tqchen
Copy link
Member

tqchen commented Nov 10, 2023

cc @junrushao @cyx-6

@junrushao
Copy link
Member

I think we should move all KVCache logic to MLC LLM instead, given we expect plenty of variants of KVCache implementation. @tqchen @davidpissarra what do you guys think?

@tqchen
Copy link
Member

tqchen commented Nov 10, 2023

Yes, i think moving to mlc is OK, we can move back if there is a point of stablization.

@davidpissarra
Copy link
Contributor Author

I think we should move all KVCache logic to MLC LLM instead, given we expect plenty of variants of KVCache implementation. @tqchen @davidpissarra what do you guys think?

Thanks @junrushao! Makes sense to move KVCache to MLC LLM

@tqchen tqchen closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants