Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SME][TOPI] Add conv2d NHWC SME fp16->fp32 schedule #17048

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

Anndrey24
Copy link
Contributor

This commit extends the SME conv2d NHWC schedule to support convolutions with float16 inputs (data and kernel) and a float32 output using the tensor intrinsics added in #16981.

cc @ekalda @lhutton1

This commit extends the SME conv2d NHWC schedule to support convolutions with float16 inputs (data and kernel) and a float32 output using the tensor intrinsics added in apache#16981.
Copy link
Contributor

@ekalda ekalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Anndrey24 LGTM!

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay taking a look.. looks great! I just had a couple of questions around handling the weights

python/tvm/relay/op/strategy/arm_cpu.py Show resolved Hide resolved
python/tvm/topi/arm_cpu/conv2d_alter_op.py Show resolved Hide resolved
python/tvm/topi/arm_cpu/conv2d.py Show resolved Hide resolved
python/tvm/topi/arm_cpu/conv2d.py Show resolved Hide resolved
python/tvm/topi/arm_cpu/conv2d.py Show resolved Hide resolved
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ekalda ekalda merged commit 4b82974 into apache:main Jun 5, 2024
20 checks passed
@ekalda
Copy link
Contributor

ekalda commented Jun 5, 2024

Thanks @Anndrey24 and @lhutton1!

@Anndrey24 Anndrey24 deleted the sme-conv2d-fp16 branch June 5, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants