-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Bootstrap 4 #200
Comments
I would like to work on this issue, is there anything I should be careful about when implementing BS4 that you can think of? |
There's a lot of inline styling we do that can be replaced with BS4 utility classes (for a start). All the themes need to be tested as well :) I believe Bootswatch has updated theirs. Nothing else comes to mind immediately. One would hope this isn't too many large changes! Also note that this might not actually be possible if Bootstrap beta is buggy and we might not merge it until BS4 goes past beta depending on how much is different and how confident we feel. Regardless, go for it! Thanks for asking :) |
Hello! Also, could I ask a few questions:
|
Sure!
Yes and replace any redundant classes that exist in BS4.
We don't use Node/Ruby/C in this project so adding the SASS compiler is a no-go. However, the themed version could be built using the SASS compiler and then used in the repo. Note that this project already supports some notion of theming from bootswatch.com via the |
https://getbootstrap.com/
The text was updated successfully, but these errors were encountered: