Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bootstrap 4 #200

Closed
sushain97 opened this issue Aug 23, 2017 · 6 comments
Closed

Upgrade to Bootstrap 4 #200

sushain97 opened this issue Aug 23, 2017 · 6 comments

Comments

@sushain97
Copy link
Member

sushain97 commented Aug 23, 2017

https://getbootstrap.com/

@efeichen
Copy link

efeichen commented Dec 5, 2017

I would like to work on this issue, is there anything I should be careful about when implementing BS4 that you can think of?

@sushain97
Copy link
Member Author

sushain97 commented Dec 5, 2017

There's a lot of inline styling we do that can be replaced with BS4 utility classes (for a start). All the themes need to be tested as well :) I believe Bootswatch has updated theirs. Nothing else comes to mind immediately.

One would hope this isn't too many large changes! Also note that this might not actually be possible if Bootstrap beta is buggy and we might not merge it until BS4 goes past beta depending on how much is different and how confident we feel.

Regardless, go for it! Thanks for asking :)

@myfrom
Copy link
Contributor

myfrom commented Nov 13, 2018

Hello!
Could I take this as part of a GCI Task (as well as #314 since it's related)?
I'd like to make sure it still needs to be worked on and that no-one has taken this already.

Also, could I ask a few questions:

  • As far as I understand, the only required thing with the upgrade is to preserve current look of the website, right?
  • And what are the build tools used in this project? Could it be extended with SASS compiler? Because it's the easiest way to theme Bootstrap 4 AFAIK.

@sushain97
Copy link
Member Author

Sure!

As far as I understand, the only required thing with the upgrade is to preserve current look of the website, right?

Yes and replace any redundant classes that exist in BS4.

And what are the build tools used in this project? Could it be extended with SASS compiler? Because it's the easiest way to theme Bootstrap 4 AFAIK.

We don't use Node/Ruby/C in this project so adding the SASS compiler is a no-go. However, the themed version could be built using the SASS compiler and then used in the repo. Note that this project already supports some notion of theming from bootswatch.com via the make [theme] target.

@sushain97
Copy link
Member Author

#355

@MaathavanJkr
Copy link
Contributor

#356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants