Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data masking] Ensure data masking works with @defer payloads #12037

Closed
jerelmiller opened this issue Aug 27, 2024 · 2 comments · Fixed by #12114
Closed

[Data masking] Ensure data masking works with @defer payloads #12037

jerelmiller opened this issue Aug 27, 2024 · 2 comments · Fixed by #12114
Labels
🐞 bug 🎭 data-masking Issues/PRs related to data masking
Milestone
Data masking

Comments

@jerelmiller
Copy link
Member

We do not currently have any tests that check a payload that might have missing keys due to the use of @defer. This is likely broken and will need fixed, but at minimum we should include some tests to check against this.
@jerelmiller jerelmiller added 🐞 bug 🎭 data-masking Issues/PRs related to data masking labels Aug 27, 2024
@jerelmiller jerelmiller added this to the Data masking milestone Aug 27, 2024
@jerelmiller jerelmiller mentioned this issue Nov 8, 2024
Merged
@jerelmiller jerelmiller linked a pull request Nov 8, 2024 that will close this issue
[Data masking] Add tests to ensure deferred payloads are masked #12114
Merged
@jerelmiller
Copy link
Member Author

Finished with #12114

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug 🎭 data-masking Issues/PRs related to data masking
Projects
None yet
Milestone
Data masking
Development

Successfully merging a pull request may close this issue.

[Data masking] Add tests to ensure deferred payloads are masked apollographql/apollo-client
1 participant
@jerelmiller