HttpRequest.newBuilder() does not preserve executionContext

[varahash]

Version

4.1.0

Summary

The HttpRequest.newBuilder() is a convenient function for creating copy of HttpRequest to modify it, as an user I expect that it copies all data from original request. But unfortunately it does so for all fields except executionContext field.
The problem with this is when you have a chain of HttpInterceptor's and each depends on executionContext you must make sure that all interceptors in the chain also uses HttpRequest.Builder.addExecutionContext() to avoid bugs with missing executionContext.

Please consider copying executionContext field in HttpRequest.newBuilder() by default, as it done with other fields.

Steps to reproduce the behavior

No response

Logs

No response

[martinbonnin]

This was most likely an oversight as executionContext was added after the fact. Thanks for noticing it 🙏

Do you want to open a pull request to add this?

[varahash]

Yes, I will create PR

[martinbonnin]

Thanks! Let me know if you need anything. This should happen around here

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Kotlin usage and allow us to serve you better.