-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Mirage URL #168
Comments
@geraldclark I believe the place you can change this in the code is here - dejavu/live/src/js/helper/urlShare.js Line 107 in c5901fa
You can then build your own image using the Dockerfile. |
@siddharthlatest Thanks identifying the code. As I mentioned on the mirage ticket (for visibility), I was just thinking it might be beneficial to allow for an external configuration as I'd prefer to not have to build a custom docker image or modify the core app source. |
Linking to that thread - appbaseio/mirage#56 (comment). Happy to accept a PR for this or any other configuration use-cases that someone may have. |
I don't mind taking a look. Would you be looking for this to be part of the initial app build process or would an ajax query fetching the config suffice? |
@geraldclark That would be cool! I am thinking of this to be set as an ENV var which can be passed directly at Docker runtime. Something like Edit: On a second thought, this would require the app build process to happen. What would an ajax query fetching the config look like? |
This is not relevant anymore as we ship Mirage as |
Is there a recommended approach for updating the mirage "Query View" url to a local docker instance of mirage?
The text was updated successfully, but these errors were encountered: