Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Mirage URL #168

Closed
geraldclark opened this issue Mar 6, 2018 · 6 comments
Closed

Custom Mirage URL #168

geraldclark opened this issue Mar 6, 2018 · 6 comments

Comments

@geraldclark
Copy link

Is there a recommended approach for updating the mirage "Query View" url to a local docker instance of mirage?

@siddharthlatest
Copy link
Member

@geraldclark I believe the place you can change this in the code is here -

var final_url = 'https://appbaseio.github.io/mirage/#?input_state=' + ciphertext;
.

You can then build your own image using the Dockerfile.

@geraldclark
Copy link
Author

@siddharthlatest Thanks identifying the code. As I mentioned on the mirage ticket (for visibility), I was just thinking it might be beneficial to allow for an external configuration as I'd prefer to not have to build a custom docker image or modify the core app source.

@siddharthlatest
Copy link
Member

Linking to that thread - appbaseio/mirage#56 (comment).

Happy to accept a PR for this or any other configuration use-cases that someone may have.

@geraldclark
Copy link
Author

I don't mind taking a look. Would you be looking for this to be part of the initial app build process or would an ajax query fetching the config suffice?

@siddharthlatest
Copy link
Member

siddharthlatest commented Mar 6, 2018

@geraldclark That would be cool! I am thinking of this to be set as an ENV var which can be passed directly at Docker runtime. Something like -E MIRAGE_HOST=http://localhost:3030.

Edit: On a second thought, this would require the app build process to happen.

What would an ajax query fetching the config look like?

@siddharthlatest
Copy link
Member

This is not relevant anymore as we ship Mirage as Query Explorer within Dejavu itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants