Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocket confirmations only for in-wallet accounts #3

Open
guilhermelawless opened this issue Feb 7, 2020 · 2 comments · May be fixed by #37
Open

Websocket confirmations only for in-wallet accounts #3

guilhermelawless opened this issue Feb 7, 2020 · 2 comments · May be fixed by #37

Comments

@guilhermelawless
Copy link
Contributor

guilhermelawless commented Feb 7, 2020 •
edited
Loading

The websocket can be setup with options to request confirmations only from some accounts: https://docs.nano.org/integration-guides/websockets/#confirmations

In V21, it is possible to incrementally update the list of accounts with an "update" action.
@guilhermelawless guilhermelawless mentioned this issue Feb 8, 2020
Closed
This was referenced Jun 15, 2024
Closed
Open
@dylan1951
Copy link
Contributor

This would be good because public nodes don't allow block confirmation subscriptions for all blocks so it would be good to setup the per address filtering.

@dylan1951
Copy link
Contributor

dylan1951 commented Jun 15, 2024 •
edited
Loading

NanoRPCProxy doesn't have the incremental update thing introduced in V21 unfortunately so I think we have to resubscribe with the whole list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add address filtering to websocket block confirmation subscription dylan1951/pippin_nano_wallet
2 participants
@guilhermelawless @dylan1951