Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: Add support for Winget installation #1274

Open
PedromfRibeiro opened this issue Jan 2, 2024 · 8 comments
Open

feature request: Add support for Winget installation #1274

PedromfRibeiro opened this issue Jan 2, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@PedromfRibeiro
Copy link

PedromfRibeiro commented Jan 2, 2024

Current Behavior

No package found on Winget, to automate processes and simplify things.
Is it possible to add the appium inspector to the Winget repository?

Suggested Solution

PackageIdentifier: Appium.AppiumInspector
PackageVersion: 2023.12.2
Platform:
- Windows.Desktop
InstallerType: nullsoft
InstallModes:
- interactive
- silent
UpgradeBehavior: install
ReleaseDate: 2023-12-02
Installers:
- Architecture: x64
  Scope: user
  InstallerUrl: https://github.com/appium/appium-inspector/releases/download/v2023.12.2/Appium-Inspector-windows-2023.12.2-x64.exe
  InstallerSha256: ??
  InstallerSwitches:
    Custom: /CURRENTUSER
- Architecture: x86
  Scope: machine
  InstallerUrl: https://github.com/appium/appium-inspector/releases/download/v2023.12.2/Appium-Inspector-windows-2023.12.2.exe
  InstallerSha256: ??
  InstallerSwitches:
    Custom: /ALLUSERS
ManifestType: installer
ManifestVersion: ??

Additional Information

No response

@PedromfRibeiro PedromfRibeiro added the enhancement New feature or request label Jan 2, 2024
@eglitise
Copy link
Collaborator

eglitise commented Jan 2, 2024

I'm not sure how publishing on Winget works, but I'm going to guess that they won't accept executables without proper signing (#1134)

@KazuCocoa
Copy link
Member

@Dor-bl @laolubenson Do you have good resources to learn to publish inspector for Win env via Winget repo?
https://github.com/appium/appium-inspector/releases

@Dor-bl
Copy link

Dor-bl commented Jan 2, 2024

Sorry, but I haven't worked with winget so far.

I assume a good starting point would be :
https://learn.microsoft.com/en-us/windows/package-manager/package/

@PedromfRibeiro
Copy link
Author

Referencing PR: microsoft/winget-pkgs#133597
Since Winget is a comunity based input i took the liberty to start the procedure;
Steps taken:

  • cmd -> winget install wingetcreate
  • cmd -> wingetcreate token
  • cmd -> wingetcreate new
    • Fill informations

@jlipps
Copy link
Member

jlipps commented Jan 10, 2024

thanks @PedromfRibeiro , looks nice! something seems off with the version reported there in the PR though?

@PedromfRibeiro
Copy link
Author

You're welcome @jlipps!
True, the version is indeed partially wrong, the PR is waiting for a community moderator to approve it, so i'll try to change it

Change the PackageVersion with the value "2023.12.2.20231220.2" to "2023.12.2", can you confirm?

@PedromfRibeiro
Copy link
Author

Well, the PR was aproved right now.
I can wait for the next version to update the manifest or make a new PR tomorrow

@jlipps
Copy link
Member

jlipps commented Jan 11, 2024

yes, 2023.12.2 is correct. actual release versions are found here: https://github.com/appium/appium-inspector/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants