-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include C++ implementations of BoringSSL algorithms #300
Comments
Thanks for filing this @fpseverino! Let's nail this down before we move forward on #278 and #267, as I'd like us to make sure we aren't going to regress those. |
I agree @Lukasa! This will need a BoringSSL update too, right? Is it something that I can/should do? |
It's going to be a lot easier for me to do it than you, I suspect |
All right, just to clarify, would you also take care of updating the script or would you prefer me to do it? |
I can update the script as well. 😄 |
Huh, turns out that we timed this work well, as that immediately became 100% necessary! https://boringssl.googlesource.com/boringssl/+/5813c2c10c73d800f1b0d890a7d74ff973abbffc |
In BoringSSL some algorithms, like ML-KEM and ML-DSA, are written in C++, but the
vendor-boringssl.sh
script doesn't look for.cc
files inside BoringSSL’scrypto
directory.New Issue Checklist
main
branch)Expected behavior
Being able to use methods from algorithms written in C++
Actual behavior
Not being able to use methods from algorithms written in C++
Steps to reproduce
Sources/CCryptoBoringSSL/include/CCryptoBoringSSL.h
CCryptoBoringSSL
CCryptoBoringSSL_xxx
method of an algorithm written in C++Swift Crypto version/commit hash
commit: ff0f781
Environment
The text was updated successfully, but these errors were encountered: