Fix windows creation of relative symlinks to directories #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmschonfeld
requested review from
compnerd,
parkera,
iCharlesHu and
itingliu
|
@swift-ci please test |
compnerd
reviewed
Sep 19, 2024
Sources/FoundationEssentials/FileManager/FileManager+SymbolicLinks.swift
Show resolved
Hide resolved
compnerd
approved these changes
Sep 20, 2024
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test macOS platform |
iCharlesHu
approved these changes
Sep 23, 2024
jmschonfeld
added a commit
to jmschonfeld/swift-foundation
that referenced
this pull request
Sep 23, 2024
* Fix windows creation of relative symlinks to directories * Add additional unit tests * Fix windows test failure
jmschonfeld
added a commit
to jmschonfeld/swift-foundation
that referenced
this pull request
Sep 23, 2024
* Fix windows creation of relative symlinks to directories * Add additional unit tests * Fix windows test failure
jmschonfeld
added a commit
that referenced
this pull request
Sep 26, 2024
jmschonfeld
added a commit
that referenced
this pull request
Sep 26, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
* Fix windows creation of relative symlinks to directories * Add additional unit tests * Fix windows test failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows, we need to specify an extra flag if we are creating a symlink to a directory. To do this, we check if the provided destination is a directory using
FileManager.fileExists(atPath:isDirectory:). However, the destination path is relative to the symlink and not relative to the current working directory likefileExists(atPath:)expects so we must first convert the relative path into an absolute path using the symlink path as a base.Resolves #928