Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime check to Decimal(sign:exponent:significand:) for bin compat #933

Merged

Conversation

iCharlesHu
Copy link
Contributor

Add runtime check to revert back to old behavior for Decimal(sign:exponent:significand:) if the app was build on older OSs.

resolves: rdar://135822747
resolves: #833

@iCharlesHu iCharlesHu marked this pull request as ready for review September 19, 2024 22:26
@iCharlesHu
Copy link
Contributor Author

@swift-ci please test

@iCharlesHu
Copy link
Contributor Author

@swift-ci please test

@iCharlesHu iCharlesHu merged commit 13b563e into swiftlang:main Sep 20, 2024
3 checks passed
cthielen pushed a commit to cthielen/swift-foundation that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decimal(sign:exponent:significand:) causes unexpected sign if significand is negative
3 participants