java-openliberty: Server create failure doesn't fail appsody run or test in validate

[scottkurz]

In the middle of work on the v0.2.0 java-openliberty stack we had a permission error, however the appsody stack validate failed to report a failure for each of the run and test checks.

The logs were:

[Container] [INFO] Running liberty:create
[Container] [INFO] CWWKM2102I: Using pre-installed assembly : /opt/ol/wlp.
[Container] [INFO] CWWKM2102I: Using serverName : defaultServer.
[Container] [INFO] CWWKM2102I: Using serverDirectory : /opt/ol/wlp/usr/servers/defaultServer.
[Container] [INFO] CWWKM2107I: Installation type is pre-existing; skipping installation.
[Container] [INFO] CWWKM2143I: Server defaultServer does not exist. Now creating...
[Container] [INFO] CWWKM2001I: Invoke command is [/opt/ol/wlp/bin/server, create, defaultServer].
[Container] [INFO]
[Container] [INFO] CWWKE0005E: The runtime environment could not be launched.
[Container] [INFO] CWWKE0066E: A directory cannot be created for the defaultServer server at the following location: /opt/ol/wlp/usr/servers/defaultServer.
[Container] [INFO]                  Java home:  /opt/java/openjdk/jre
[Container] [INFO]               Install root:  /opt/ol/wlp/
[Container] [INFO]           System libraries:  /opt/ol/wlp/lib/
[Container] [INFO]                  User root:  /opt/ol/wlp/usr/
[Container] [INFO]                     Config:  /opt/ol/wlp/usr/servers/defaultServer/
[Container] [INFO]                     Output:  /opt/ol/wlp/usr/servers/defaultServer/
[Container] [INFO]
[Container] [INFO] ------------------------------------------------------------------------
[Container] [INFO] BUILD FAILURE
[Container] [INFO] ------------------------------------------------------------------------
[Container] [INFO] Total time:  10.414 s
[Container] [INFO] Finished at: 2020-02-11T16:31:03Z
[Container] [INFO] ------------------------------------------------------------------------
[Container] [ERROR] Failed to execute goal io.openliberty.tools:liberty-maven-plugin:3.2:dev (default-cli) on project starter-app: CWWKM2002E: Failed to invoke [/opt/ol/wlp/bin/server, create, defaultServer]. RC= 23 but expected=[0]. -> [Help 1]
[Container] [ERROR]
[Container] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[Container] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[Container] [ERROR]
[Container] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[Container] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[Container] + set +x
[Container] The file watcher is not running because no APPSODY_RUN/TEST/DEBUG_ON_CHANGE action was specified or it has been disabled using the --no-watcher flag.
Closing down development environment.
[Error] Appsody run failed

At this point, we'd need to reverse engineer the stack a bit in order to recreate this (it's somewhere in someone's reflog), since we didn't stop to open the issue right then (my bad).

But I'd start my making something in the stack image's Open Liberty install root-owned, or something like that.