From b094e81afec9ea2209ed607158a68c5296f31e72 Mon Sep 17 00:00:00 2001 From: Elad Shechter Date: Thu, 11 Apr 2024 11:10:41 +0100 Subject: [PATCH 1/4] Modal - update spacing logic for modal with seperate header --- packages/ui/src/7-components/_modal.scss | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/packages/ui/src/7-components/_modal.scss b/packages/ui/src/7-components/_modal.scss index 8a88adf142..26d9906fe5 100644 --- a/packages/ui/src/7-components/_modal.scss +++ b/packages/ui/src/7-components/_modal.scss @@ -69,11 +69,14 @@ } } &.is-separate-header { - > .modal-form > .modal-header { - padding: var(--p-modal-padding); - padding-block-start: 0; - border-block-end: solid pxToRem(1) hsl(var(--color-border)); - margin-inline: calc(var(--p-modal-padding) * -1); + > .modal-form { + > .modal-header { + padding: var(--p-modal-padding); padding-block-start: 0; + border-block-end: solid pxToRem(1) hsl(var(--color-border)); + margin-inline: calc(var(--p-modal-padding) * -1); margin-block-end:0; + } + > .modal-content { padding-block:var(--p-modal-padding); } + > .modal-footer { scroll-margin-block-start:0; } } } &.is-page-in-mobile { From 3e431a1d9aa0c78df583e5700385c2ce524cd931 Mon Sep 17 00:00:00 2001 From: Elad Shechter Date: Mon, 15 Apr 2024 14:47:47 +0100 Subject: [PATCH 2/4] Add utility class with size of 1px --- packages/ui/src/7-components/_modal.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ui/src/7-components/_modal.scss b/packages/ui/src/7-components/_modal.scss index 26d9906fe5..e2b031e4ed 100644 --- a/packages/ui/src/7-components/_modal.scss +++ b/packages/ui/src/7-components/_modal.scss @@ -76,7 +76,7 @@ margin-inline: calc(var(--p-modal-padding) * -1); margin-block-end:0; } > .modal-content { padding-block:var(--p-modal-padding); } - > .modal-footer { scroll-margin-block-start:0; } + > .modal-footer { margin-block-start:0; } } } &.is-page-in-mobile { From e02d5b217849b74400121692a55216b6670bd821 Mon Sep 17 00:00:00 2001 From: Elad Shechter Date: Mon, 15 Apr 2024 15:20:02 +0100 Subject: [PATCH 3/4] small fix --- packages/ui/src/7-components/_modal.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ui/src/7-components/_modal.scss b/packages/ui/src/7-components/_modal.scss index e2b031e4ed..e47a103fa6 100644 --- a/packages/ui/src/7-components/_modal.scss +++ b/packages/ui/src/7-components/_modal.scss @@ -75,7 +75,7 @@ border-block-end: solid pxToRem(1) hsl(var(--color-border)); margin-inline: calc(var(--p-modal-padding) * -1); margin-block-end:0; } - > .modal-content { padding-block:var(--p-modal-padding); } + > .modal-content { padding-block:var(--p-modal-padding); margin-block:0; } > .modal-footer { margin-block-start:0; } } } From f6558d24340614b783e4838bfb828687669e6ff0 Mon Sep 17 00:00:00 2001 From: Arman Date: Tue, 16 Apr 2024 11:06:12 +0200 Subject: [PATCH 4/4] Create rare-lemons-know.md --- .changeset/rare-lemons-know.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/rare-lemons-know.md diff --git a/.changeset/rare-lemons-know.md b/.changeset/rare-lemons-know.md new file mode 100644 index 0000000000..a665c85f70 --- /dev/null +++ b/.changeset/rare-lemons-know.md @@ -0,0 +1,6 @@ +--- +"@appwrite.io/pink": minor +"@appwrite.io/pink-icons": minor +--- + +Modal