Feat step component #240
Merged
Feat step component #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
ArmanNik
requested changes
Nov 28, 2024
Comment on lines
38
to
107
| .stepitem { | ||
| padding: 24px 29px; | ||
| position: relative; | ||
|
|
||
| &::before { | ||
| content: ''; | ||
| position: absolute; | ||
| background-color: var(--color-light-neutral-10, #ededf0); | ||
| width: 1px; | ||
| height: 100%; | ||
| margin-left: -30px; | ||
| z-index: -2; | ||
| } | ||
| } | ||
|
|
||
| .stepitem.noline::before { | ||
| display: none; | ||
| } | ||
|
|
||
| .stepitem.shortline::before { | ||
| height: calc(100% - 50px); | ||
| } | ||
|
|
||
| .dot-inactive { | ||
| width: 7px; | ||
| aspect-ratio: 1/1; | ||
| border-radius: 50%; | ||
| background-color: var(--color-light-neutral-10, #ededf0); | ||
| margin-left: -33px; | ||
| position: absolute; | ||
| } | ||
|
|
||
| .dot-active { | ||
| width: 16px; | ||
| height: 17px; | ||
| position: absolute; | ||
| margin-left: -37px; | ||
| margin-top: -3px; | ||
| background-color: var(--color-bgcolor-neutral-primary); | ||
| } | ||
|
|
||
| .dot-active::before { | ||
| content: ''; | ||
| width: 1px; | ||
| height: 80px; | ||
| background: linear-gradient( | ||
| to bottom, | ||
| rgba(253, 54, 110, 0) 0%, | ||
| rgba(253, 54, 110, 1) 50%, | ||
| rgba(253, 54, 110, 0) 100% | ||
| ); | ||
| margin-left: 7px; | ||
| position: absolute; | ||
| margin-top: -30px; | ||
| z-index: -1; | ||
| } | ||
|
|
||
| .badge { | ||
| position: absolute; | ||
| margin-top: -9px; | ||
|
|
||
| img { | ||
| width: 20px; | ||
| height: 20px; | ||
| } | ||
| } | ||
|
|
||
| .badge-margin { | ||
| margin-top: 30px; | ||
| } |
There was a problem hiding this comment.
There are a lot of hardcoded pixel sizes... let's try to use the existing sizes variables where possible, and maybe we can ask design if we can round some of the other sizes
There was a problem hiding this comment.
Yeah it's a bit of a challenge to get the all the separate dots and lines to exactly match. But I've expressed it into the existing vars as much as possible now!
| background-color: var(--color-light-neutral-10, #ededf0); | ||
| width: 1px; | ||
| height: 100%; | ||
| margin-left: -30px; |
There was a problem hiding this comment.
Let's fututre proof this and use margin-inline and margin-block when possible
There was a problem hiding this comment.
Ayy nice, you learn every day! Done!
ArmanNik
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add Step component to V2
Have you read the Contributing Guidelines on issues?
✅