Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Unit Tests #680

Open
8 of 18 tasks
stnguyen90 opened this issue Jun 22, 2023 · 22 comments
Open
8 of 18 tasks

🚀 Feature: Unit Tests #680

stnguyen90 opened this issue Jun 22, 2023 · 22 comments
Assignees
Labels
hacktoberfest Issues that can win you some cool merchandise! help wanted Extra attention is needed

Comments

@stnguyen90
Copy link
Contributor

stnguyen90 commented Jun 22, 2023

💭 Description

Add unit tests for each SDK

For reference on how to do this, refer to the Flutter/Dart templates: #673

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@stnguyen90 stnguyen90 added the help wanted Extra attention is needed label Jun 22, 2023
@tewarig
Copy link

tewarig commented Jun 27, 2023

can i work on this ? would love to add test for web

@lohanidamodar
Copy link
Member

@tewarig sure you can get started.

@prathamesh3707
Copy link

i would like to work

@leonyangela
Copy link

Hi @Haimantika, can I work on node?? Thank you

@Haimantika
Copy link

i would like to work

Hi @prathamesh3707 have assigned the issue to you! Thank you for showing interest in contributing to Appwrite! Happy Hacktoberfest 🎃

Notes:

Please update us with your progress every 3 days, so that we know that you are working on it.
Join us on Discord - https://appwrite.io/discord to chat about Hacktoberfest and Appwrite!

@Haimantika
Copy link

Hi @Haimantika, can I work on node?? Thank you

Hi, we are assigning issues on first-come first-serve basis. If @prathamesh3707 drops/is unresponsive, will assign it to you.

@Haimantika
Copy link

Hi @prathamesh3707 any update? This issue will soon be reassigned to the next person due to inactivity

@prathamesh3707
Copy link

sorry, i saw it just now. Thanks for assigning it to me! I am working on it

@Haimantika
Copy link

sorry, i saw it just now. Thanks for assigning it to me! I am working on it

Hi, let us know in Discord if you have any questions :)

@prathamesh3707
Copy link

Ya sure , I need a little help in getting started , I'll ask there. Is there any deadline for this?

@prathamesh3707 prathamesh3707 removed their assignment Oct 13, 2023
@mvarendorff
Copy link
Contributor

mvarendorff commented Oct 13, 2023

Heyyo! I would like to pick this up if possible. Let me know and I'll get started soon :)

@airwakz
Copy link

airwakz commented Oct 14, 2023

@Haimantika can i work on this

@ujju200
Copy link

ujju200 commented Oct 15, 2023

Can I work on this issue?

@Haimantika
Copy link

@leonyangela you are up next, would you like to work on it?

@stnguyen90
Copy link
Contributor Author

@leonyangela, the assignee would need to work on all the languages. Would you still like to work on this?

@leonyangela
Copy link

Hi @stnguyen90 @Haimantika thanks for mentioning me, I’m not sure if I can do it for all languages, you can assign it to the next person. Thanks

@Haimantika
Copy link

Heyyo! I would like to pick this up if possible. Let me know and I'll get started soon :)

Hi, you are up next, would you like to work on it?

@mvarendorff
Copy link
Contributor

@Haimantika yes, I'd love to!

@mvarendorff
Copy link
Contributor

Alrighties, I can give a quick update already!

I have started working on Kotlin / Android test and what I am relatively sure about is that I won't finish all languages and frameworks by the end of the month; they are just too many and I am not familiar with unit testing or even the language at all in them (never written any Ruby or Swift before for example). On top of that, I might even have to tweak some stuff here or there; the Android SDK for example is not really fit for (generated) unit testing because it relies on generics to return stuff which is not really nicely mockable. The Dart / Flutter SDK on the other hand uses a helper Response class which is handled by each Service internally which is something I am likely to copy over to the Kotlin one.

Since I am not sure how many of such bumps I am going to encounter, I just wanted to let you know that it's probably not going to be done by October 31st. I will put up a draft PR as soon as I have one of the checkboxes ticked though and will update as often as I can!

@mvarendorff
Copy link
Contributor

3 day update: Kotlin and Android now share the same testsuite and a bit of the generated SDK's code (where it was easily doable). I don't know if it makes more sense to have individual PRs per SDK (genuinely orga-wise, not because I am greedy for PRs)?

@mvarendorff
Copy link
Contributor

Next 3(-ish) day update! I am working fulltime next to this so I haven't been able to continue work on this in the last couple days, however plan for this weekend is tackling deno (and probably in extension node).

Question @stnguyen90 : Would you rather have separate PRs per language / framework (or group of them in case of android/kotlin) or everything in one?

@mvarendorff
Copy link
Contributor

Heyyo, quick update: I will hold off on working on the remaining ones (ruby, swift and web(?)) for now since all changes made to the SDK (like the Query.between serialization) require quite some work updating all the active branches. So for the time being my last goal is fixing the pipeline for the Android / Kotlin PR and then stay quiet for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues that can win you some cool merchandise! help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

9 participants